Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Invariant failure in connector pool #2552
I don't have time to investigate right now, so dropping this here.
Just saw a surprising failure from AZP while testing the Linux + PG10 build. Could be something transient, but I thought that those invariant checks were....invariant.
edit: Also failed in the next build, so doesn't look transient.
edit (again): This also doesn't appear to be PG10 related. I've seen this fail a few times on 9.6 too. Nothing on 11 yet, but that could be build-order related (e.g. the PG11 build fires off before the others).
@roji This may actually be the double close issue I also fixed in the PR. If at all possible we should do some extra work there to make it 'impossible' to do a double release by accident. I'm not certain at all that every double close (which then results in a double release) is patched, so something to head it off entirely would make me much more comfortable.