Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reflection from connection string builder #2564

Open
YohDeadfall opened this issue Aug 12, 2019 · 5 comments

Comments

@YohDeadfall
Copy link
Member

commented Aug 12, 2019

Removing reflection from the connection string builder will help to support AOT compilation and CoreRT without additional magic with rd.xml.

@roji

This comment has been minimized.

Copy link
Member

commented Aug 13, 2019

I'm not aware of any problem with reflection for AOT/CoreRT - the problem is more with code generation... Is there any reason to do this?

@YohDeadfall

This comment has been minimized.

Copy link
Member Author

commented Aug 13, 2019

The reason is rd.xml noted in #2073.

@roji

This comment has been minimized.

Copy link
Member

commented Aug 13, 2019

But rd.xml isn't really a reason to not do reflection - we just have to properly list things in there, no? Unlike unbounded code generation where things get more complicated...

@YohDeadfall

This comment has been minimized.

Copy link
Member Author

commented Aug 13, 2019

It's better to avoid adding the same things in multiple places since there's no chance to forget fix it somewhere else.

@roji

This comment has been minimized.

Copy link
Member

commented Aug 19, 2019

Which same thing are we doing in multiple places?

The thing with DbConnectionStringBuilder is that it requires us to expose two APIs: strongly-typed properties and a weakly-typed dictionary-like interface. Reflection allows us to build the latter over the former.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.