More consistent key/value parsing in NpgsqlConnectionStringBuilder #17

Merged
merged 2 commits into from May 8, 2013

2 participants

@roji
Npgsql member

.NET's DbConnectionStringBuilder, which NpgsqlConnectionStringBuilder extends, trims strings values and discards pairs with empty ones. However, NCSB's setter behaved differently, adding empty strings, leading to inconsistent behavior (bug #1011001).

Modified NCSB's behavior to be consistent with DCSB - trim and discard empty.

This is a replacement of #15 (after the migration to github)

roji added some commits Apr 13, 2013
@roji roji Indentation and empty newlines in StringBuilder 2d13051
@roji roji More consistent key/value parsing in NpgsqlConnectionStringBuilder
.NET's DbConnectionStringBuilder, which NpgsqlConnectionStringBuilder extends,
trims strings values and discards pairs with empty ones. However, NCSB's setter
behaved differently, adding empty strings, leading to inconsistent behavior
(bug #1011001).

Modified NCSB's behavior to be consistent with DCSB - trim and discard empty.
59c4735
@franciscojunior franciscojunior merged commit 689e9ce into npgsql:master May 8, 2013
@franciscojunior
Npgsql member

I confirm this patch fix the bug #1011001 on pgfoundry.

Thanks for this fix, Shay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment