New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target NodaTime 2.4.0 #2162

Merged
merged 1 commit into from Sep 23, 2018

Conversation

Projects
None yet
2 participants
@austindrenski
Member

austindrenski commented Sep 19, 2018

Closes: #2161

@roji

roji approved these changes Sep 19, 2018

Looks good, not sure we should bump to 1.1.0 because of a dependency change. We probably need to rethink once again how to manage versions for the plugins, maybe it's not so bad to simply make them follow Npgsql (so Npgsql.NodaTime 4.0.x would be usable with Npgsql 4.0.x), because realistically speaking the plugin API may very well change between minor/major versions. Same for the EF Core plugins.

Am still not sure about which strategy we should use here.

@roji

This comment has been minimized.

Show comment
Hide comment
@roji

roji Sep 19, 2018

Member

Don't forget to do a similar dependency change on the EF Core NodaTime plugin.

Member

roji commented Sep 19, 2018

Don't forget to do a similar dependency change on the EF Core NodaTime plugin.

@austindrenski

This comment has been minimized.

Show comment
Hide comment
@austindrenski

austindrenski Sep 19, 2018

Member

@roji Would it be better to bring it back down to 1.0.1 , or should we take the leap and move it to 4.0.4?

Speaking as a consumer, I like the idea of alignment, especially if you're okay updating dependencies on patch releases. (Dealing with these downgrade errors until the 4.1 release would be a pain.)

Member

austindrenski commented Sep 19, 2018

@roji Would it be better to bring it back down to 1.0.1 , or should we take the leap and move it to 4.0.4?

Speaking as a consumer, I like the idea of alignment, especially if you're okay updating dependencies on patch releases. (Dealing with these downgrade errors until the 4.1 release would be a pain.)

@roji

This comment has been minimized.

Show comment
Hide comment
@roji

roji Sep 20, 2018

Member

See discussion in #2104

Member

roji commented Sep 20, 2018

See discussion in #2104

@austindrenski austindrenski changed the title from Target NodaTime 2.4.0 for 1.1.0 release to Target NodaTime 2.4.0 Sep 21, 2018

@austindrenski

This comment has been minimized.

Show comment
Hide comment
@austindrenski

austindrenski Sep 21, 2018

Member

@roji Changed the version to 4.1.0, will also backport for 4.0.4.

Member

austindrenski commented Sep 21, 2018

@roji Changed the version to 4.1.0, will also backport for 4.0.4.

@roji

This comment has been minimized.

Show comment
Hide comment
@roji

roji Sep 23, 2018

Member

@austindrenski FYI this looks good to me, feel free to merge.

Member

roji commented Sep 23, 2018

@austindrenski FYI this looks good to me, feel free to merge.

@austindrenski austindrenski merged commit 925f73a into npgsql:dev Sep 23, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@austindrenski austindrenski deleted the austindrenski:nodatime-2.4.0 branch Sep 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment