Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align versions for CI artifact consistency #2528

Merged

Conversation

@austindrenski
Copy link
Member

commented Jul 16, 2019

We've talked about this before (or maybe that was regarding EF Core), but I can't recall where we left it.

Targeting CI builds of Npgsql and friends (i.e. plugins) is causing me grief on the EF Core side. Opening this to get a clean set of CI artifacts for some testing.

@austindrenski austindrenski requested review from roji and YohDeadfall as code owners Jul 16, 2019

@austindrenski austindrenski self-assigned this Jul 16, 2019

@YohDeadfall
Copy link
Member

left a comment

Except one place, everything looks good.

Directory.Build.props Outdated Show resolved Hide resolved

@austindrenski austindrenski force-pushed the austindrenski:where-are-the-plugin-ci-packages branch from 1e8c600 to b2309cb Jul 16, 2019

@roji

This comment has been minimized.

Copy link
Member

commented Jul 17, 2019

@austindrenski no problem for fixing these build issues, but aren't we still planning to move to Azure Devops? Seems better to invest in that rather than fix the Appveyor config no?

@austindrenski

This comment has been minimized.

Copy link
Member Author

commented Jul 17, 2019

@roji Yeah... Just chasing cheap fixes with these. But you're right, we should just (finally) make the leap.

On the EF Core side, I just merged npgsql/Npgsql.EntityFrameworkCore.PostgreSQL#646. I'll try to go over that config again tonight and submit another PR to bring it into line with the latest .appveyor.yml. Then I'll backport it to 2.1.x and 2.2.x for the sake of uniformity.

If that works out, I can take over updating #2158 too.

@austindrenski

This comment has been minimized.

Copy link
Member Author

commented Jul 19, 2019

Merging this to put things in the right state for #2537.

@austindrenski austindrenski merged commit 950e314 into npgsql:dev Jul 19, 2019

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@austindrenski austindrenski deleted the austindrenski:where-are-the-plugin-ci-packages branch Jul 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.