Work on Unit Tests + Mono #7

Closed
wants to merge 2 commits into
from

Projects

None yet

2 participants

@roji
Member
roji commented Oct 25, 2012

Hi again Francisco.

Here's a pull request that fixes some problems in the unit test SQL init scripts - take a look at these (do these scripts actually work for you?).

Also added the MonoNotSupported NUnit category which excludes the System.Transaction tests, at least for now (I've just submitted a pull request to mono to add support for this). However, like you said there are still many failing tests (nothing to do with mono apparently).

Once you decide what to do with the xmlModel generated tests (how to exclude for mono, or just disable them for now?) I think you'll have a fully functioning mono-friendly xbuild system.

Shay Rojansky added some commits Oct 25, 2012
Shay Rojansky Corrections to tests SQL scripts c156584
Shay Rojansky Added MonoNotSupported unit tests category
System.Transactions does not work in mono yet. Added a unit test category to allow easy exclusion of these tests.
c4cc98b
@franciscojunior
Member

Hi, Shay!

Yeah, they work ok. But I think some escape values I made them work by enabling legacy escaping chars. Newer versions of Postgresql wouldn't accept that. Thanks for fixing them. We would need to test them with Postgresql 7.x to check if everything is ok. I'll do that.

Thanks for the new category. I think it will help very much to get cleaner test results.

About the xmlModel I'll check with Josh Cooley. Sorry for the delay.

Thanks, Shay for your patches. I'll start integrate them soon. I'll apply your patches to cvs as well because cvs is still the official code repository for Npgsql.

@roji
Member
roji commented Oct 26, 2012

My pleasure to help Francisco. I'll be looking a bit more into the problem with the ambient transactions, hope Josh will have time to look at this soon...

@franciscojunior
Member

I just committed your changes to our official repository at pgfoundry.org
I also did a slightly change to your patch regarding the value of the bytea. I added the \123\056 because \456 was wrong since beginning. Postgresql was being relaxed about this octet value and was translating it to 056. I'll soon update git to reflect this pull request.

@roji roji closed this Sep 23, 2013
@gencer gencer pushed a commit to gencer/Npgsql2 that referenced this pull request Apr 11, 2014
fxjr Fixed test data insertion and function creation script. Thanks Shay R…
…ojansky for patches. See npgsql#7 for more information.
94e6425
@kenjiuno kenjiuno added a commit to kenjiuno/Npgsql that referenced this pull request May 21, 2014
@kenjiuno kenjiuno Step #7: Add Microsoft.VisualStudio.Shell.Immutable.10.0.dll to the t…
…ools directory
22e197c
@kenjiuno kenjiuno added a commit to kenjiuno/Npgsql that referenced this pull request May 21, 2014
@kenjiuno kenjiuno Fix: Step #7: Add Microsoft.VisualStudio.Shell.Immutable.10.0.dll to …
…the tools directory
72f7922
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment