Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better --force message, correct config.force documentation #1259

Closed
wants to merge 1 commit into from

Conversation

isaacs
Copy link
Contributor

@isaacs isaacs commented May 8, 2020

While the 'I sure hope you know what you are doing' was always intended as
a sincere and genuine hope, people tend to read it in a variety of ways,
and it doesn't provide much information.

This is an alternative to #1244, which I think is still a little judgey,
and not very informative. Let's just tell people what's going on.

Close: #1244

While the 'I sure hope you know what you are doing' was always intended
as a sincere and genuine hope, people tend to read it in a variety of
ways, and it doesn't provide much information.

This is an alternative to #1244, which I think is still a little judgey,
and not very informative.  Let's just tell people what's going on.

Close: #1244
@isaacs isaacs force-pushed the isaacs/better-force-message branch from b73977b to 29be2e8 Compare May 8, 2020 02:24
@richardeschloss
Copy link

richardeschloss commented May 17, 2020

I know I'll probably be hated for saying this, but I actually like the original intended message of "I hope you know what you're doing" because it's possible that the user could potentially break things. Just like a smoke alarm creates a sound that is anything but pleasing, it's good that it makes that sound because it causes the person to react. If it played the same music you hear in yoga class, the building would probably burn down.

I think the better solution is already provided by the npm cli, in the form of log level and warnings options. (--quiet or --silent is probably the better option for the minority of users who don't like seeing warning messages that are their largely for their benefit).

Update: Or, perhaps even better...allow the string to be configurable. Have it default to what it was...then if users want to change it, it'd be something like npm config set [force warning str] [your favorite string]. Then that removes the concern entirely from the codebase.

@isaacs
Copy link
Contributor Author

isaacs commented May 18, 2020

@richardeschloss Certainly not hated by me, and likely hated a lot less than I have been for this message 😆

That is, I agree with you, but we're in the minority here, I think. It does get misinterpreted pretty often, and isn't as informative or helpful as it could be.

@darcyclarke darcyclarke added this to the OSS - Sprint 8 milestone Jun 1, 2020
isaacs pushed a commit that referenced this pull request Jun 5, 2020
The current warning is not an actual help message, is not suggesting any
actions, and it's quite condescending.

While the 'I sure hope you know what you are doing' was always intended
as a sincere and genuine hope, people tend to read it in a variety of
ways, and it doesn't provide any helpful information.

PR-URL: #1259
Credit: @pablocubico
Close: #1259
Close: #1244
Reviewed-by: @isaacs
@isaacs
Copy link
Contributor Author

isaacs commented Jul 17, 2020

This is landed in the release/v7.0.0-beta branch. Closing.

@isaacs isaacs closed this Jul 17, 2020
@isaacs isaacs deleted the isaacs/better-force-message branch October 2, 2020 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants