Skip to content

Conversation

@isaacs
Copy link
Contributor

@isaacs isaacs commented Jul 11, 2019

No description provided.

isaacs and others added 30 commits July 3, 2019 10:08
When running an npm command from within a git environment, such as
installing or testing during a git rebase or bisect, these environment
variables will be passed to the child process, causing it to
fetch/checkout/etc in the root project instead of doing what the user
intends.

Strip them out so that they are not passed to the child process.

Also, remove git environs from the test environment, so that spawning
git in a test to set up a dummy repo doesn't mess with the main
project's git repository.  This enables adding `exec npm test` in a `git
rebase -i` list to run tests between commits.
This also updates make-fetch-happen, so it no longer requires the old
lru-cache.
Instead of creating a new set each time a new node gets visited, so that
its siblings do not have it in `seen`, just remove the node from the
original set right after all child nodes are visited.

See #76

Credit: @larsgw

PR-URL: #206
Close: #206
Reviewed-by: @isaacs
Credit: @raywu0123
PR-URL: #179
Close: #179
Reviewed-by: @isaacs
This handles an EISDIR error from cacache on Darwin in Node versions
prior to 10.6.

Fix: [npm.community#7901](https://npm.community/t/7901/)
Fix: [npm.community#8203](https://npm.community/t/8203/)
Fix: isaacs/chownr#20
PR-URL: isaacs/chownr#21
PR-URL: #208
Close: #208
Credit: @irega
Reviewed-by: @isaacs
rsmarples and others added 6 commits July 10, 2019 15:10
On BSD platforms, there is a clear seperation between the OS and third
party packages. Here, bash is a third party package so it won't be
installed to /bin.

FreeBSD:	/usr/local/bin/bash
NetBSD:		/usr/pkg/bin/bash
OpenBSD:	/usr/ports/bin/bash

As such, we need to use /usr/bin/env to launch these scripts.

Credit: @rsmarples
PR-URL: #212
Close: #212
Reviewed-by: @isaacs
Addresses replace-var-with-let/const

Credit: @RobertJGabriel
PR-URL: #211
Close: #211
Reviewed-by: @isaacs
@isaacs isaacs requested a review from a team as a code owner July 11, 2019 17:14
@isaacs
Copy link
Contributor Author

isaacs commented Jul 11, 2019

Just waiting on Travis to complete. I'd forgotten to update the semver doc when I updated the semver module. Yay tests :)

@isaacs
Copy link
Contributor Author

isaacs commented Jul 11, 2019

Just noticed that there are a few commits in there where my email address is nope@not.real. That's me getting bit by the problem fixed in 3cbd577. The official 6.10.1 release will be properly signed and github-verified, and shouldn't be an issue again in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants