Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

token: use figgy-config to make sure extra opts are there #149

Merged
merged 1 commit into from Jan 30, 2019

Conversation

Projects
None yet
3 participants
@zkat
Copy link
Member

zkat commented Jan 28, 2019

This fixes a reversion reported by @evilpacket and co, where we weren't sending some metadata and auth info on npm token ls. This has to do with the npm@6.6.0 rework.

@zkat zkat added the semver:patch label Jan 28, 2019

@zkat zkat requested a review from npm/cli-team as a code owner Jan 28, 2019

@zkat zkat force-pushed the zkat/fix-token branch from 2312376 to b61b8a1 Jan 29, 2019

@aeschright
Copy link
Contributor

aeschright left a comment

⭐️

@aeschright aeschright merged commit ce2c4bd into release-next Jan 30, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@aeschright aeschright deleted the zkat/fix-token branch Jan 30, 2019

@alexsasharegan

This comment has been minimized.

Copy link

alexsasharegan commented Feb 5, 2019

Will this also resolve what looks like the same issue with the token subcommand? This output immediately follows a successful login. Of note, I do use TOTP 2FA.

$ npm token create --read-only
npm password: 
npm ERR! code E401
npm ERR! Unable to authenticate, your authentication token seems to be invalid.
npm ERR! To correct this please trying logging in again with:
npm ERR!     npm login

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/alex/.npm/_logs/2019-02-05T17_41_20_882Z-debug.log
/home/alex/.npm/_logs/2019-02-05T17_41_20_882Z-debug.log
0 info it worked if it ends with ok
1 verbose cli [ '/usr/bin/node',
1 verbose cli   '/usr/bin/npm',
1 verbose cli   'token',
1 verbose cli   'create',
1 verbose cli   '--read-only' ]
2 info using npm@6.7.0
3 info using node@v10.15.1
4 verbose config Skipping project config: /home/alex/.npmrc. (matches userconfig)
5 info token creating
6 verbose stack Error: Unable to authenticate, need: Basic, Bearer
6 verbose stack     at res.buffer.catch.then.body (/home/alex/.npm-global/lib/node_modules/npm/node_modules/npm-registry-fetch/check-response.js:94:17)
6 verbose stack     at process._tickCallback (internal/process/next_tick.js:68:7)
7 verbose statusCode 401
8 verbose cwd /home/alex/github.com/pictalk/pictalk
9 verbose Linux 4.18.0-13-generic
10 verbose argv "/usr/bin/node" "/usr/bin/npm" "token" "create" "--read-only"
11 verbose node v10.15.1
12 verbose npm  v6.7.0
13 error code E401
14 error Unable to authenticate, your authentication token seems to be invalid.
15 error To correct this please trying logging in again with:
15 error     npm login
16 verbose exit [ 1, true ]

aeschright added a commit that referenced this pull request Feb 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.