Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

throw an error when trying to dedupe in global mode #2716

Merged
merged 1 commit into from Feb 18, 2021

Conversation

@nlf
Copy link
Contributor

@nlf nlf commented Feb 17, 2021

as described in #2620 it doesn't make much sense to globally dedupe, and clearly the wrong thing happens. let's just fail immediately instead of potentially breaking global packages.

References

Closes #2620

@nlf nlf requested a review from as a code owner Feb 17, 2021
ljharb
ljharb approved these changes Feb 17, 2021
Copy link
Collaborator

@ljharb ljharb left a comment

it would be awesome to backport this into npm 6, in the event another patch release goes out

@nlf nlf changed the base branch from latest to release/v7.5.5 Feb 18, 2021
@nlf nlf force-pushed the nlf/no-global-dedupe branch from f1c6024 to 69e0c4e Feb 18, 2021
@nlf nlf merged commit 69e0c4e into release/v7.5.5 Feb 18, 2021
@nlf nlf mentioned this pull request Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants