Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runScript): obey silent loglevel #2719

Merged
merged 1 commit into from Feb 22, 2021
Merged

fix(runScript): obey silent loglevel #2719

merged 1 commit into from Feb 22, 2021

Conversation

@wraithgar
Copy link
Contributor

@wraithgar wraithgar commented Feb 17, 2021

If the user has specified a silent loglevel, we should pass that intention on
when we call runScript

Also a small cleanup in lib/run-script.js so that the reference to
@npmcli/run-script is named the same as other files.

@wraithgar
Copy link
Contributor Author

@wraithgar wraithgar commented Feb 17, 2021

This is still a draft till the same changes can be made in pacote, libnpmpack, and libnpmversion.

@wraithgar wraithgar marked this pull request as ready for review Feb 18, 2021
@wraithgar wraithgar requested a review from as a code owner Feb 18, 2021
nlf
nlf approved these changes Feb 19, 2021
Copy link
Contributor

@nlf nlf left a comment

🎉

@wraithgar
Copy link
Contributor Author

@wraithgar wraithgar commented Feb 19, 2021

All of the places where we're calling runScript outside of the cli code itself have been updated and are in the v7.5.5 release branch. This should go along with them.

If the user has specified a silent loglevel, we should pass that intention on
when we call runScript

Also a small cleanup in lib/run-script.js so that the reference to
@npmcli/run-script is named the same as other files.

PR-URL: #2719
Credit: @wraithgar
Close: #2719
Reviewed-by: @nlf
@nlf nlf changed the base branch from latest to release/v7.5.5 Feb 22, 2021
@nlf nlf force-pushed the gar/silent-run-script branch from 0071184 to b018eb8 Feb 22, 2021
@nlf nlf merged commit b018eb8 into release/v7.5.5 Feb 22, 2021
@nlf nlf mentioned this pull request Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants