Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(search): don't pass unused args #2803

Merged
merged 1 commit into from Mar 4, 2021
Merged

fix(search): don't pass unused args #2803

merged 1 commit into from Mar 4, 2021

Conversation

@wraithgar
Copy link
Contributor

@wraithgar wraithgar commented Mar 1, 2021

The searchopts get parsed and added to the query elsewhere, they're not
part of the include array they are an extra querystring that is added
to the search request.

These already make it to the search request, this was dead code.

References

Closes #2791

@wraithgar wraithgar requested a review from as a code owner Mar 1, 2021
The searchopts get parsed and added to the query elsewhere, they're not
part of the `include` array they are an extra querystring that is added
to the search request.

PR-URL: #2803
Credit: @wraithgar
Close: #2803
Reviewed-by: @ruyadorno
@ruyadorno ruyadorno changed the base branch from latest to release/v7.6.1 Mar 4, 2021
@ruyadorno ruyadorno merged commit 2d682e4 into release/v7.6.1 Mar 4, 2021
@ruyadorno ruyadorno mentioned this pull request Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants