Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved repository examples #36

Merged
merged 2 commits into from Aug 3, 2018
Merged

Improved repository examples #36

merged 2 commits into from Aug 3, 2018

Conversation

@noahbenham
Copy link
Contributor

@noahbenham noahbenham commented Aug 1, 2018

This better reflects the syntax expected when declaring the repository field.

@noahbenham noahbenham requested a review from as a code owner Aug 1, 2018
zkat
zkat approved these changes Aug 2, 2018
Copy link
Contributor

@zkat zkat left a comment

👍 yeah, that looks nicer these days for sure 😅

@zkat zkat added the docs label Aug 2, 2018
@zkat zkat changed the base branch from latest to release-next Aug 3, 2018
@zkat zkat merged commit e2b0f09 into npm:release-next Aug 3, 2018
2 checks passed
2 checks passed
@travis-ci[bot]
Travis CI - Pull Request Build Passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
isaacs added a commit that referenced this issue Aug 12, 2019
- [`9c93ac3`](npm/cmd-shim@9c93ac3)
  [#2](npm/cmd-shim#2)
  [#3380](npm/npm#3380)
  Handle environment variables properly
  ([@basbossink](https://github.com/basbossink))

- [`2d277f8`](npm/cmd-shim@2d277f8)
  [#25](npm/cmd-shim#25)
  [#36](npm/cmd-shim#36)
  [#35](npm/cmd-shim#35) Fix 'no shebang' case
  by always providing `$basedir` in shell script
  ([@igorklopov](https://github.com/igorklopov))

- [`adaf20b`](npm/cmd-shim@adaf20b)
  [#26](npm/cmd-shim#26) Fix `$*` causing an
  error when arguments contain parentheses
  ([@satazor](https://github.com/satazor))

- [`49f0c13`](npm/cmd-shim@49f0c13)
  [#30](npm/cmd-shim#30) Fix paths for
  MSYS/MINGW bash ([@dscho](https://github.com/dscho))

- [`51a8af3`](npm/cmd-shim@51a8af3)
  [#34](npm/cmd-shim#34) Add proper support for
  PowerShell ([@ExE-Boss](https://github.com/ExE-Boss))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants