Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: fix no-proxy to noproxy #46

Merged
merged 1 commit into from Aug 20, 2018
Merged

Conversation

@SneakyFish5
Copy link
Contributor

@SneakyFish5 SneakyFish5 commented Aug 13, 2018

Hello,

This is my first PR and I was looking through the NPM bug forum and saw this good-first-patch. Saw @zkat's fix and decided to open the PR. Sorry if this is wrong.

@SneakyFish5 SneakyFish5 requested a review from as a code owner Aug 13, 2018
@SneakyFish5 SneakyFish5 force-pushed the fix-no-proxy branch 2 times, most recently from 6321a5c to cf8e85f Aug 14, 2018
zkat
zkat approved these changes Aug 14, 2018
Copy link
Contributor

@zkat zkat left a comment

No, this is perfect. You did great! Thanks for the patch! 🎉

@SneakyFish5
Copy link
Contributor Author

@SneakyFish5 SneakyFish5 commented Aug 14, 2018

Thank you 😃

@zkat zkat changed the base branch from latest to release-next Aug 20, 2018
@zkat zkat merged commit 05f473f into npm:release-next Aug 20, 2018
2 checks passed
2 checks passed
@travis-ci[bot]
Travis CI - Pull Request Build Passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@SneakyFish5 SneakyFish5 deleted the fix-no-proxy branch Aug 20, 2018
zkat added a commit that referenced this issue Aug 20, 2018
@zkat zkat mentioned this pull request Aug 29, 2018
4 tasks
@apaprocki
Copy link

@apaprocki apaprocki commented Sep 25, 2018

@zkat Doesn't this have the nasty side effect of breaking everyone's npmrc that is using a private registry and a required no-proxy setting to access it?

isaacs added a commit that referenced this issue Aug 5, 2019
FEATURES

* [bbcf7b2](npm/hosted-git-info@bbcf7b2)
  [#46](npm/hosted-git-info#46)
  [#43](npm/hosted-git-info#43)
  [#47](npm/hosted-git-info#47)
  [#44](npm/hosted-git-info#44) Add support for
  GitLab groups and subgroups ([@mterrel](https://github.com/mterrel),
  [@isaacs](https://github.com/isaacs),
  [@ybiquitous](https://github.com/ybiquitous))

BUGFIXES

* ([3b1d629](npm/hosted-git-info@3b1d629))
  [#48](npm/hosted-git-info#48) fix http protocol
  using sshurl by default ([@fengmk2](https://github.com/fengmk2))
* [5d4a8d7](npm/hosted-git-info@5d4a8d7) ignore
  noCommittish on tarball url generation
  ([@isaacs](https://github.com/isaacs))
* [1692435](npm/hosted-git-info@1692435) use gist
  tarball url that works for anonymous gists
  ([@isaacs](https://github.com/isaacs))
* [d5cf830](npm/hosted-git-info@d5cf830)
* Do not allow invalid gist urls ([@isaacs](https://github.com/isaacs))
* [e518222](npm/hosted-git-info@e518222)
  Use LRU cache to prevent unbounded memory consumption
  ([@iarna](https://github.com/iarna))
wraithgar added a commit that referenced this issue May 26, 2021
 * fix(exit-code): account for null auditLevel default (#46)
@wraithgar wraithgar mentioned this pull request May 27, 2021
@wraithgar wraithgar mentioned this pull request May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants