Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update republish time and lightly reorganize republish info #48

Merged
merged 3 commits into from Aug 20, 2018

Conversation

@neverett
Copy link
Contributor

@neverett neverett commented Aug 14, 2018

In this PR:

  • Update to correct package republish time (24 hours)
  • Light reorganization of republish info for clarity
@neverett neverett requested a review from as a code owner Aug 14, 2018
package again, a new version number must be used.
version combination can never be reused. In order to publish the
package again, a new version number must be used. Additionally,
new versions of unpublished packages may not be republished until 24 hours
Copy link
Collaborator

@ljharb ljharb Aug 15, 2018

This doesn’t seem accurate; new versions can be published immediately, altho the old version can never be republished.

Is this a new requirement?

Copy link
Contributor

@iarna iarna Aug 15, 2018

Entirely unpublished packages have a 24 hour delay before they can be published again. This isn't particularly new, but it's not widely known, thus these docs.

Copy link
Collaborator

@ljharb ljharb Aug 15, 2018

ahhh ok so it’s only if there remains no published versions, then there’s a 24 hour delay?

Maybe the wording here could be like “fully unpublished” or “new versions of packages with every version unpublished”, so it’s clearer?

Copy link
Contributor

@zkat zkat Aug 15, 2018

I like that rewording, tbh.

@neverett
Copy link
Contributor Author

@neverett neverett commented Aug 17, 2018

Thanks @ljharb! Updated with your wording.

ljharb
ljharb approved these changes Aug 17, 2018
Copy link
Collaborator

@ljharb ljharb left a comment

Much clearer to me, thanks <3

zkat
zkat approved these changes Aug 20, 2018
Copy link
Contributor

@zkat zkat left a comment

🎉 🐑 🚀 💥

The only thing that'd be nice is if you wrapped the modified lines to the same length as their surrounding lines, but that's not a big deal if you don't get around to it.

Thank you!

@zkat zkat removed the in-progress label Aug 20, 2018
@zkat zkat changed the base branch from latest to release-next Aug 20, 2018
@zkat zkat merged commit 8ed3546 into release-next Aug 20, 2018
0 of 4 checks passed
0 of 4 checks passed
@travis-ci[bot]
Travis CI - Pull Request Build Errored
Details
@travis-ci[bot]
Travis CI - Branch Build Failed
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
@zkat zkat deleted the ne-unpublish branch Aug 20, 2018
zkat added a commit that referenced this issue Aug 20, 2018
isaacs added a commit that referenced this issue Aug 5, 2019
FEATURES

* [bbcf7b2](npm/hosted-git-info@bbcf7b2)
  [#46](npm/hosted-git-info#46)
  [#43](npm/hosted-git-info#43)
  [#47](npm/hosted-git-info#47)
  [#44](npm/hosted-git-info#44) Add support for
  GitLab groups and subgroups ([@mterrel](https://github.com/mterrel),
  [@isaacs](https://github.com/isaacs),
  [@ybiquitous](https://github.com/ybiquitous))

BUGFIXES

* ([3b1d629](npm/hosted-git-info@3b1d629))
  [#48](npm/hosted-git-info#48) fix http protocol
  using sshurl by default ([@fengmk2](https://github.com/fengmk2))
* [5d4a8d7](npm/hosted-git-info@5d4a8d7) ignore
  noCommittish on tarball url generation
  ([@isaacs](https://github.com/isaacs))
* [1692435](npm/hosted-git-info@1692435) use gist
  tarball url that works for anonymous gists
  ([@isaacs](https://github.com/isaacs))
* [d5cf830](npm/hosted-git-info@d5cf830)
* Do not allow invalid gist urls ([@isaacs](https://github.com/isaacs))
* [e518222](npm/hosted-git-info@e518222)
  Use LRU cache to prevent unbounded memory consumption
  ([@iarna](https://github.com/iarna))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants