Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(arborist): use rawSpec for bundled and shrinkwrapped deps #4963

merged 1 commit into from Jun 1, 2022


Copy link

@nlf nlf commented May 31, 2022

we don't apply overrides to shrinkwrapped or bundled dependencies as a side effect today, however we are currently marking them as invalid because of that

this change makes it so that bundled and shrinkwrapped dependencies will never be overridden in an explicit way, as well as resolves the npm ls errors that can occur in this situation.

closes #4889

@nlf nlf requested a review from a team as a code owner May 31, 2022 19:52
@ruyadorno ruyadorno merged commit 646b6b5 into latest Jun 1, 2022
44 checks passed
@ruyadorno ruyadorno deleted the nlf/arborist-no-ls-errors-with-overrides branch June 1, 2022 21:13
@ruyadorno ruyadorno mentioned this pull request Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

[BUG] Overrides not working for some transitive dependencies, cause ERR ELSPROBLEMS in npm ls
2 participants