Skip to content

feat(audit): do not run audit outside of project locations #5684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukekarrys merged 1 commit into from
Oct 19, 2022
Merged

feat(audit): do not run audit outside of project locations #5684

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions workspaces/arborist/lib/arborist/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,12 @@ class Arborist extends Base {
replaceRegistryHost: options.replaceRegistryHost,
lockfileVersion: lockfileVersion(options.lockfileVersion),
installStrategy: options.global ? 'shallow' : (options.installStrategy ? options.installStrategy : 'hoisted'),
location: options.global ? 'global' : options.location,
}
// don't audit when run in a non-project location
this.options.audit = (!this.options.location || this.options.location === 'project')
&& options.audit !== false

this.replaceRegistryHost = this.options.replaceRegistryHost =
(!this.options.replaceRegistryHost || this.options.replaceRegistryHost === 'npmjs') ?
'registry.npmjs.org' : this.options.replaceRegistryHost
Expand Down
10 changes: 10 additions & 0 deletions workspaces/arborist/test/arborist/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,3 +253,13 @@ t.test('valid global/installStrategy values', t => {
t.equal(new Arborist({ installStrategy: 'hoisted' }).options.installStrategy, 'hoisted')
t.end()
})

t.test('disable audit when location is not project', t => {
t.equal(new Arborist({ location: 'global' }).options.audit, false)
t.equal(new Arborist({ location: undefined }).options.audit, true)
t.equal(new Arborist({ audit: undefined }).options.audit, true)
t.equal(new Arborist({ audit: false, location: 'project' }).options.audit, false)
t.equal(new Arborist({ global: true }).options.audit, false)
t.equal(new Arborist({ global: false }).options.audit, true)
t.end()
})