Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Validate username at get-identity #5884

merged 4 commits into from Nov 30, 2022

fix: Validate username at get-identity #5884

merged 4 commits into from Nov 30, 2022


Copy link

@sosoba sosoba commented Nov 22, 2022

Currently npm accept null / undefined / empty string as valid username.
Client should validate incomming data.


Fixes #5867 (prevent undefined username)

Fix for npm#5867 (prevent undefined username)
@sosoba sosoba requested a review from a team as a code owner November 22, 2022 06:09
@sosoba sosoba changed the title Update get-identity.js fix: Validate username at get-identity Nov 22, 2022
lib/utils/get-identity.js Outdated Show resolved Hide resolved
Co-authored-by: nlf <>
@fritzy fritzy merged commit c26d708 into npm:latest Nov 30, 2022
25 checks passed
@github-actions github-actions bot mentioned this pull request Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

[BUG] npm whoami allow empty username
3 participants