From 089f37f3669dc041579b7a602c236e8a8364b523 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sat, 27 Sep 2025 20:27:16 -0400 Subject: [PATCH 1/8] chore: Improve grammar: `; otherwise,` Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- tap-snapshots/test/lib/docs.js.test.cjs | 8 ++++---- workspaces/config/lib/definitions/definition.js | 2 +- workspaces/config/lib/definitions/definitions.js | 8 ++++---- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/tap-snapshots/test/lib/docs.js.test.cjs b/tap-snapshots/test/lib/docs.js.test.cjs index 046729e50626f..fd0f2baeaac71 100644 --- a/tap-snapshots/test/lib/docs.js.test.cjs +++ b/tap-snapshots/test/lib/docs.js.test.cjs @@ -405,7 +405,7 @@ are same as \`cpu\` field of package.json, which comes from \`process.arch\`. #### \`depth\` -* Default: \`Infinity\` if \`--all\` is set, otherwise \`0\` +* Default: \`Infinity\` if \`--all\` is set; otherwise, \`0\` * Type: null or Number The depth to go when recursing packages for \`npm ls\`. @@ -992,8 +992,8 @@ instead of the current working directory. See #### \`lockfile-version\` -* Default: Version 3 if no lockfile, auto-converting v1 lockfiles to v3, - otherwise maintain current lockfile version. +* Default: Version 3 if no lockfile, auto-converting v1 lockfiles to v3; + otherwise, maintain current lockfile version. * Type: null, 1, 2, 3, "1", "2", or "3" Set the lockfile format version to be used in package-lock.json and @@ -1129,7 +1129,7 @@ allow the CLI to fill in missing cache data, see \`--prefer-offline\`. #### \`omit\` * Default: 'dev' if the \`NODE_ENV\` environment variable is set to - 'production', otherwise empty. + 'production'; otherwise, empty. * Type: "dev", "optional", or "peer" (can be set multiple times) Dependency types to omit from the installation tree on disk. diff --git a/workspaces/config/lib/definitions/definition.js b/workspaces/config/lib/definitions/definition.js index 333a91928526e..30ccc50614301 100644 --- a/workspaces/config/lib/definitions/definition.js +++ b/workspaces/config/lib/definitions/definition.js @@ -34,7 +34,7 @@ const { class Definition { constructor (key, def) { this.key = key - // if it's set falsey, don't export it, otherwise we do by default + // if it's set falsey, don't export it; otherwise, we do by default this.envExport = true Object.assign(this, def) this.validate() diff --git a/workspaces/config/lib/definitions/definitions.js b/workspaces/config/lib/definitions/definitions.js index caa834d823ed6..7275984e7b91f 100644 --- a/workspaces/config/lib/definitions/definitions.js +++ b/workspaces/config/lib/definitions/definitions.js @@ -462,7 +462,7 @@ const definitions = { depth: new Definition('depth', { default: null, defaultDescription: ` - \`Infinity\` if \`--all\` is set, otherwise \`0\` + \`Infinity\` if \`--all\` is set; otherwise, \`0\` `, type: [null, Number], description: ` @@ -1205,7 +1205,7 @@ const definitions = { default: null, type: [null, 1, 2, 3, '1', '2', '3'], defaultDescription: ` - Version 3 if no lockfile, auto-converting v1 lockfiles to v3, otherwise + Version 3 if no lockfile, auto-converting v1 lockfiles to v3; otherwise, maintain current lockfile version.`, description: ` Set the lockfile format version to be used in package-lock.json and @@ -1356,8 +1356,8 @@ const definitions = { omit: new Definition('omit', { default: process.env.NODE_ENV === 'production' ? ['dev'] : [], defaultDescription: ` - 'dev' if the \`NODE_ENV\` environment variable is set to 'production', - otherwise empty. + 'dev' if the \`NODE_ENV\` environment variable is set to 'production'; + otherwise, empty. `, type: [Array, 'dev', 'optional', 'peer'], description: ` From 2bf7200a89ad7cf6a5299151ab2ef59951ff09a9 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sat, 27 Sep 2025 22:12:09 -0400 Subject: [PATCH 2/8] chore: fix spelling: affect Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- workspaces/config/lib/set-envs.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/workspaces/config/lib/set-envs.js b/workspaces/config/lib/set-envs.js index 30e175dae867f..12719b5647836 100644 --- a/workspaces/config/lib/set-envs.js +++ b/workspaces/config/lib/set-envs.js @@ -97,7 +97,7 @@ const setEnvs = (config) => { env.EDITOR = cliConf.editor } - // note: this doesn't afect the *current* node process, of course, since + // note: this doesn't affect the *current* node process, of course, since // it's already started, but it does affect the options passed to scripts. if (cliConf['node-options']) { env.NODE_OPTIONS = cliConf['node-options'] From c5f72d7ee1874d7c13e8d9e1b85e493a24ff906c Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sat, 27 Sep 2025 20:27:24 -0400 Subject: [PATCH 3/8] chore: fix grammar: an Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- workspaces/config/test/index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/workspaces/config/test/index.js b/workspaces/config/test/index.js index a4dca9ec58890..7d20fe11b20fe 100644 --- a/workspaces/config/test/index.js +++ b/workspaces/config/test/index.js @@ -422,7 +422,7 @@ loglevel = yolo t.notOk(config.isDefault('cli-config'), 'should return false for a cli-defined value') t.notOk(config.isDefault('foo'), - 'should return false for a env-defined value') + 'should return false for an env-defined value') t.notOk(config.isDefault('project-config'), 'should return false for a project-defined value') t.notOk(config.isDefault('default-user-config-in-home'), From 6c57c32ddeba44bfb10e6f0f575753f3ec54e053 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sun, 28 Sep 2025 17:08:43 -0400 Subject: [PATCH 4/8] chore: fix spelling: calamities Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- workspaces/config/lib/index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/workspaces/config/lib/index.js b/workspaces/config/lib/index.js index 9c1fad0c59f62..c731006129539 100644 --- a/workspaces/config/lib/index.js +++ b/workspaces/config/lib/index.js @@ -672,7 +672,7 @@ class Config { // if we're in the ~ directory, and there happens to be a node_modules // folder (which is not TOO uncommon, it turns out), then we can end // up loading the "project" config where the "userconfig" will be, - // which causes some calamaties. So, we only load project config if + // which causes some calamities. So, we only load project config if // it doesn't match what the userconfig will be. if (projectFile !== this.#get('userconfig')) { return this.#loadFile(projectFile, 'project') From d883b9dd32dfc104198af030c9c89a2e4d93599d Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sat, 27 Sep 2025 20:52:01 -0400 Subject: [PATCH 5/8] chore: fix spelling: cannot Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- tap-snapshots/test/lib/docs.js.test.cjs | 18 +++++++++--------- .../config/lib/definitions/definition.js | 2 +- .../config/lib/definitions/definitions.js | 2 +- workspaces/config/lib/index.js | 2 +- .../test/definitions/definition.js.test.cjs | 2 +- workspaces/config/test/index.js | 2 +- 6 files changed, 14 insertions(+), 14 deletions(-) diff --git a/tap-snapshots/test/lib/docs.js.test.cjs b/tap-snapshots/test/lib/docs.js.test.cjs index fd0f2baeaac71..3e4a8f08b391e 100644 --- a/tap-snapshots/test/lib/docs.js.test.cjs +++ b/tap-snapshots/test/lib/docs.js.test.cjs @@ -195,7 +195,7 @@ safer to use a registry-provided authentication bearer token stored in the If you do not want your scoped package to be publicly viewable (and installable) set \`--access=restricted\`. -Unscoped packages can not be set to \`restricted\`. +Unscoped packages cannot be set to \`restricted\`. Note: This defaults to not changing the current access level for existing packages. Specifying a value of \`restricted\` or \`public\` during publish will @@ -544,7 +544,7 @@ This can be overridden by setting the \`--force\` flag. Tells to expect a specific number of results from the command. -This config can not be used with: \`expect-results\` +This config cannot be used with: \`expect-results\` #### \`expect-results\` @@ -554,7 +554,7 @@ This config can not be used with: \`expect-results\` Tells npm whether or not to expect results from the command. Can be either true (expect some results) or false (expect no results). -This config can not be used with: \`expect-result-count\` +This config cannot be used with: \`expect-result-count\` #### \`fetch-retries\` @@ -1309,7 +1309,7 @@ Set to \`false\` to suppress the progress bar. When publishing from a supported cloud CI/CD system, the package will be publicly linked to where it was built and published from. -This config can not be used with: \`provenance-file\` +This config cannot be used with: \`provenance-file\` #### \`provenance-file\` @@ -1318,7 +1318,7 @@ This config can not be used with: \`provenance-file\` When publishing, the provenance bundle at the given path will be used. -This config can not be used with: \`provenance\` +This config cannot be used with: \`provenance\` #### \`proxy\` @@ -1410,7 +1410,7 @@ Ignored if \`--save-peer\` is set, since peerDependencies cannot be bundled. Save installed packages to a package.json file as \`devDependencies\`. -This config can not be used with: \`save-optional\`, \`save-peer\`, \`save-prod\` +This config cannot be used with: \`save-optional\`, \`save-peer\`, \`save-prod\` #### \`save-exact\` @@ -1429,7 +1429,7 @@ rather than using npm's default semver range operator. Save installed packages to a package.json file as \`optionalDependencies\`. -This config can not be used with: \`save-dev\`, \`save-peer\`, \`save-prod\` +This config cannot be used with: \`save-dev\`, \`save-peer\`, \`save-prod\` #### \`save-peer\` @@ -1438,7 +1438,7 @@ This config can not be used with: \`save-dev\`, \`save-peer\`, \`save-prod\` Save installed packages to a package.json file as \`peerDependencies\` -This config can not be used with: \`save-dev\`, \`save-optional\`, \`save-prod\` +This config cannot be used with: \`save-dev\`, \`save-optional\`, \`save-prod\` #### \`save-prefix\` @@ -1467,7 +1467,7 @@ you want to move it to be a non-optional production dependency. This is the default behavior if \`--save\` is true, and neither \`--save-dev\` or \`--save-optional\` are true. -This config can not be used with: \`save-dev\`, \`save-optional\`, \`save-peer\` +This config cannot be used with: \`save-dev\`, \`save-optional\`, \`save-peer\` #### \`sbom-format\` diff --git a/workspaces/config/lib/definitions/definition.js b/workspaces/config/lib/definitions/definition.js index 30ccc50614301..26ba0c0bc14b9 100644 --- a/workspaces/config/lib/definitions/definition.js +++ b/workspaces/config/lib/definitions/definition.js @@ -83,7 +83,7 @@ This value is not exported to the environment for child processes. ` const deprecated = !this.deprecated ? '' : `* DEPRECATED: ${unindent(this.deprecated)}\n` /* eslint-disable-next-line max-len */ - const exclusive = !this.exclusive ? '' : `\nThis config can not be used with: \`${this.exclusive.join('`, `')}\`` + const exclusive = !this.exclusive ? '' : `\nThis config cannot be used with: \`${this.exclusive.join('`, `')}\`` return wrapAll(`#### \`${this.key}\` * Default: ${unindent(this.defaultDescription)} diff --git a/workspaces/config/lib/definitions/definitions.js b/workspaces/config/lib/definitions/definitions.js index 7275984e7b91f..b2aad57833d22 100644 --- a/workspaces/config/lib/definitions/definitions.js +++ b/workspaces/config/lib/definitions/definitions.js @@ -158,7 +158,7 @@ const definitions = { If you do not want your scoped package to be publicly viewable (and installable) set \`--access=restricted\`. - Unscoped packages can not be set to \`restricted\`. + Unscoped packages cannot be set to \`restricted\`. Note: This defaults to not changing the current access level for existing packages. Specifying a value of \`restricted\` or \`public\` during diff --git a/workspaces/config/lib/index.js b/workspaces/config/lib/index.js index c731006129539..f2720e4116913 100644 --- a/workspaces/config/lib/index.js +++ b/workspaces/config/lib/index.js @@ -589,7 +589,7 @@ class Config { if (this.definitions[key]?.exclusive) { for (const exclusive of this.definitions[key].exclusive) { if (!this.isDefault(exclusive)) { - throw new TypeError(`--${key} can not be provided when using --${exclusive}`) + throw new TypeError(`--${key} cannot be provided when using --${exclusive}`) } } } diff --git a/workspaces/config/tap-snapshots/test/definitions/definition.js.test.cjs b/workspaces/config/tap-snapshots/test/definitions/definition.js.test.cjs index e405d599029ec..11c48bd946a01 100644 --- a/workspaces/config/tap-snapshots/test/definitions/definition.js.test.cjs +++ b/workspaces/config/tap-snapshots/test/definitions/definition.js.test.cjs @@ -27,7 +27,7 @@ exports[`test/definitions/definition.js TAP basic definition > description of de a number -This config can not be used with: \`x\` +This config cannot be used with: \`x\` ` exports[`test/definitions/definition.js TAP basic definition > human-readable description 1`] = ` diff --git a/workspaces/config/test/index.js b/workspaces/config/test/index.js index 7d20fe11b20fe..39d0584dbfeac 100644 --- a/workspaces/config/test/index.js +++ b/workspaces/config/test/index.js @@ -1431,7 +1431,7 @@ t.test('exclusive options conflict', async t => { }) await t.rejects(config.load(), { name: 'TypeError', - message: '--lie can not be provided when using --truth', + message: '--lie cannot be provided when using --truth', }) }) From ef0b26e67155f9b6aeffeef10ce50573248a7932 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sun, 28 Sep 2025 18:24:53 -0400 Subject: [PATCH 6/8] chore: fix spelling: definable Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- workspaces/config/lib/index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/workspaces/config/lib/index.js b/workspaces/config/lib/index.js index f2720e4116913..b56c461991c5c 100644 --- a/workspaces/config/lib/index.js +++ b/workspaces/config/lib/index.js @@ -281,7 +281,7 @@ class Config { } try { - // This does not have an actual definition because this is not user defineable + // This does not have an actual definition because this is not user definable defaultsObject['npm-version'] = require(join(this.npmPath, 'package.json')).version } catch { // in some weird state where the passed in npmPath does not have a package.json From 26f892063918feb98a6cd531f42f5af7a0ad7e48 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sat, 27 Sep 2025 23:00:45 -0400 Subject: [PATCH 7/8] chore: fix spelling: output Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- workspaces/config/CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/workspaces/config/CHANGELOG.md b/workspaces/config/CHANGELOG.md index ab62343d79c0f..a3c37e818360d 100644 --- a/workspaces/config/CHANGELOG.md +++ b/workspaces/config/CHANGELOG.md @@ -139,7 +139,7 @@ ### Features -* [`9123de4`](https://github.com/npm/cli/commit/9123de4d282bfd19ea17ad613f5a2acab0e0e162) [#7373](https://github.com/npm/cli/pull/7373) do all ouput over proc-log events (@lukekarrys) +* [`9123de4`](https://github.com/npm/cli/commit/9123de4d282bfd19ea17ad613f5a2acab0e0e162) [#7373](https://github.com/npm/cli/pull/7373) do all output over proc-log events (@lukekarrys) ### Bug Fixes From 734fc9822ac2f4014aa0966c469250b2adf8ad43 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sun, 28 Sep 2025 18:40:17 -0400 Subject: [PATCH 8/8] fix: spelling: staleness Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- workspaces/config/test/definitions/definitions.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/workspaces/config/test/definitions/definitions.js b/workspaces/config/test/definitions/definitions.js index 6a75f0d84e17b..2450413417f82 100644 --- a/workspaces/config/test/definitions/definitions.js +++ b/workspaces/config/test/definitions/definitions.js @@ -499,7 +499,7 @@ t.test('search options', t => { description: 'test description', exclude: 'test search exclude', limit: 99, - staleneess: 99, + staleness: 99, } const obj = {}