Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not pass scp-style URLs to the WhatWG url.URL #62

Closed
wants to merge 2 commits into from

Conversation

@isaacs
Copy link
Member

@isaacs isaacs commented Feb 26, 2020

Fix #60 (for the legacy branch)
Fix #61

@isaacs isaacs requested a review from darcyclarke Feb 26, 2020
Fix #61

This should not be ported to the latest branch, as Node.js v6 support
was dropped there anyway.
@billneff79
Copy link

@billneff79 billneff79 commented Feb 26, 2020

@isaacs - I put forward an alternative fix in PR #64 that gets rid of url.URL all together. I don't care which gets merged, as long as one of the fixes does

isaacs added a commit that referenced this pull request Feb 26, 2020
Fix #61

This should not be ported to the latest branch, as Node.js v6 support
was dropped there anyway.

PR-URL: #62
Credit: @isaacs
Close: #62
Reviewed-by: @isaacs
@darcyclarke
Copy link
Member

@darcyclarke darcyclarke commented Feb 27, 2020

Closing as both PRs w/ this work have landed against latest & legacy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants