Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #61 & #65 to revert breaking changes for node 6 #66

Closed

Conversation

@darcyclarke
Copy link
Member

@darcyclarke darcyclarke commented Feb 29, 2020

  • Changed const to var
  • Rewrote tests to be conditional of url.URL support
  • Updated --coverage threshold to "90" as we can't fully test in node 6 based on the url.URL implementation
@darcyclarke darcyclarke force-pushed the darcyclarke/fix-61-65-node-6-support branch from f24575d to 5b192c8 Feb 29, 2020
@darcyclarke darcyclarke force-pushed the darcyclarke/fix-61-65-node-6-support branch from 5b192c8 to 0aaac77 Feb 29, 2020
darcyclarke added a commit that referenced this pull request Feb 29, 2020
…ssed node 6 support

PR-URL: #66
Credit: @darcyclarke
Close: #66
Reviewed-by: @darcyclarke
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant