Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use validate-npm-package-license to check license values #42

Merged
merged 2 commits into from May 6, 2015
Merged

Use validate-npm-package-license to check license values #42

merged 2 commits into from May 6, 2015

Conversation

@kemitchell
Copy link
Contributor

@kemitchell kemitchell commented May 3, 2015

This PR uses a new validate-npm-package-license module to warn if a license property is not a valid SPDX license expression, and suggests correct expressions for common malformations of popular license identifiers.

I won't repeat the general comments about SPDX and current license metadata I made for npm/normalize-package-data#61 here. The two PRs are very much related. Both grow out of npm/npm#6241 and npm/npm#4473.

Best to all!

@tunnckoCore
Copy link

@tunnckoCore tunnckoCore commented May 4, 2015

👍

Loading

@kemitchell
Copy link
Contributor Author

@kemitchell kemitchell commented May 6, 2015

I force-pushed use of a revised validate-npm-package-license that uses spdx@0.4.0, which implements version 2.0 of the license expression syntax spec.

Loading

@othiym23
Copy link
Contributor

@othiym23 othiym23 commented May 6, 2015

@kemitchell Can I get a test to go with this change? The existing examples should be enough to get you started, but I can help you out if it's not clear how to write a test simulating interactivity.

Loading

@othiym23 othiym23 merged commit 78c1a69 into npm:master May 6, 2015
@othiym23
Copy link
Contributor

@othiym23 othiym23 commented May 6, 2015

Thank you for adding the test so quickly! Merged and published as init-package-json@1.5.0! Thanks for adding this!

Loading

@kemitchell
Copy link
Contributor Author

@kemitchell kemitchell commented May 6, 2015

Thanks for merging!

Loading

@kemitchell kemitchell deleted the validate-license branch May 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants