New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review youtube embed handling #274

Open
revin opened this Issue Oct 25, 2016 · 6 comments

Comments

Projects
None yet
3 participants
@revin
Collaborator

revin commented Oct 25, 2016

Similar to #258 in intent, we have a markdown-it plugin that wraps iframes pointing to youtube videos in <div class="youtube-video">…</div>. However the sanitization stuff #259 links doesn't have iframe in the whitelist, so it appears that GitHub strips them completely. I couldn't find a readme that included a youtube embed to verify this, and testing in gist comments just now didn't show me anything to indicate otherwise.

I think we can remove this altogether as it's both unused and unnecessary for GitHub compatibility.

@revin

This comment has been minimized.

Show comment
Hide comment
@revin

revin Oct 25, 2016

Collaborator

For anyone looking to make your first PR 😍 the task here is to remove the plugin file and remove the usage of it from render.js.

Collaborator

revin commented Oct 25, 2016

For anyone looking to make your first PR 😍 the task here is to remove the plugin file and remove the usage of it from render.js.

@ashleygwilliams

This comment has been minimized.

Show comment
Hide comment
@ashleygwilliams

ashleygwilliams Oct 25, 2016

Contributor

iiinteresting. maybe i'll write something to see if we have anyone using youtube videos!

Contributor

ashleygwilliams commented Oct 25, 2016

iiinteresting. maybe i'll write something to see if we have anyone using youtube videos!

@ashleygwilliams

This comment has been minimized.

Show comment
Hide comment
@ashleygwilliams

ashleygwilliams Oct 25, 2016

Contributor

ok! so i wrote a small follower here: https://github.com/ashleygwilliams/youtube-readme-follower

the results so far seem to be for packages that help embed youtube videos. or link to a youtube video and then also talk about some other type of embedding.

it occurs to me that there are a few places that npm uses marky that aren't strictly for markdown parsing of readmes, namely:

i don't think that tips on the website ever contains content with an iframe in it. the docs site definitely does. i wonder how we can handle such a thing.

it is definitely true that github crops em out tho.

i'll comment with the final results of the follower code when it finishes.

Contributor

ashleygwilliams commented Oct 25, 2016

ok! so i wrote a small follower here: https://github.com/ashleygwilliams/youtube-readme-follower

the results so far seem to be for packages that help embed youtube videos. or link to a youtube video and then also talk about some other type of embedding.

it occurs to me that there are a few places that npm uses marky that aren't strictly for markdown parsing of readmes, namely:

i don't think that tips on the website ever contains content with an iframe in it. the docs site definitely does. i wonder how we can handle such a thing.

it is definitely true that github crops em out tho.

i'll comment with the final results of the follower code when it finishes.

@revin

This comment has been minimized.

Show comment
Hide comment
@revin

revin Oct 25, 2016

Collaborator

oh nice, thanks for writing a proper follower; I just used my weeks-old readme cache I built for doing performance tests, and then $ ag 'iframe src=.*youtube.com' readmes/ which isn't very robust at all. Picked up 10 packages that, as you said, help people embed videos (so all of the iframes were actually in code snippets, not in the real docs).

Collaborator

revin commented Oct 25, 2016

oh nice, thanks for writing a proper follower; I just used my weeks-old readme cache I built for doing performance tests, and then $ ag 'iframe src=.*youtube.com' readmes/ which isn't very robust at all. Picked up 10 packages that, as you said, help people embed videos (so all of the iframes were actually in code snippets, not in the real docs).

@shibasisp

This comment has been minimized.

Show comment
Hide comment
@shibasisp

shibasisp Oct 26, 2016

I am a complete newbie and I would like to work upon it..

shibasisp commented Oct 26, 2016

I am a complete newbie and I would like to work upon it..

shibasisp added a commit to shibasisp/marky-markdown that referenced this issue Oct 26, 2016

@revin

This comment has been minimized.

Show comment
Hide comment
@revin

revin Oct 26, 2016

Collaborator

Hehe nice, @shibasisp thanks for jumping right on this! Sorry we didn't have a more solid answer to the question above sooner, I think I tweeted it out too early 😄 😕 🤔

Collaborator

revin commented Oct 26, 2016

Hehe nice, @shibasisp thanks for jumping right on this! Sorry we didn't have a more solid answer to the question above sooner, I think I tweeted it out too early 😄 😕 🤔

@revin revin removed this from the 10.0.0 milestone Jun 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment