Add support for plus sign before build number. Fixes #16. #17

Closed
wants to merge 1 commit into
from

Projects

None yet

4 participants

@JohnAlbin

Pull request for issue #16.

@domenic
Member
domenic commented Jan 9, 2013

+1

@domenic
Member
domenic commented Jan 9, 2013

Going along with this would be support for the pre-release version.

@isaacs
Member
isaacs commented Jan 9, 2013

I'm ok with this change, since it's objectively how people are actually using version number strings in the real world today, as pointed out in #16.

However, this is not actually supporting the semver.org RC spec version, as far as I can tell. With this change, 1.2.3+build.2 treats the +build.2 as a tag, not a build number. (Note that 1.2.3-2 > 1.2.3 but 1.2.3+build.2 < 1.2.3.)

@isaacs
Member
isaacs commented Jan 9, 2013

Also: Please add LOTS AND LOTS of tests. Thanks :)

@isaacs
Member
isaacs commented Jan 9, 2013

Also, with this change, "-" is no longer the smallest possible non-empty tag value, since "-" > "+". So, all the places where we're appending "-" to versions to accept any tag values (eg, so that ~1.2.3 matches 1.2.3-alpha) will have to use "+" instead, so that ~1.2.3 matches 1.2.3+alpha as well.

@JohnAlbin

urgh. 1.2.3+build.2 < 1.2.3 would not be good. So the 467fb6f commit above is insufficient.

@satazor
satazor commented Apr 22, 2013

+1

What's the status of this?

@isaacs
Member
isaacs commented Apr 22, 2013

This patch has problems. I'm ok with the intent of the change, but this is not a correct implementation. Closing.

@isaacs isaacs closed this Apr 22, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment