Skip to content

Commit

Permalink
win,node-gyp: make delay-load hook optional
Browse files Browse the repository at this point in the history
The delay-load hook that was landed in 3d46fef to make compiled addons
work on Windows regardless of the iojs.exe/node.exe filename causes
issues with a small amount of compiled addons.

Therefore this patch makes it an opt-in feature. An addon may set the
'win_delay_load_hook' option to 'true' in its binding.gyp to enable this
feature.

Example:

```
{
  'targets': [
    {
      'target_name': 'ernie',
      'win_delay_load_hook': 'true',
      ...
```

Refs: nodejs#1251
PR-URL: nodejs#1266
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
  • Loading branch information
piscisaureus authored and othiym23 committed Mar 27, 2015
1 parent 42b8907 commit cc4711a
Showing 1 changed file with 25 additions and 12 deletions.
37 changes: 25 additions & 12 deletions deps/npm/node_modules/node-gyp/addon.gypi

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit cc4711a

Please sign in to comment.