Partial read during cache update causes cache to be purged and re-downloaded in full #21

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
3 participants
@alanshaw
Contributor

alanshaw commented May 17, 2013

If you run the test against the previous code for /lib/get.js the test proves that the issue described in #20 exists i.e. somewhere during the 100 requests a failure occurs and a request for "/-/all" is sent. The test passes when run against the new /lib/get.js code in the PR.

@alanshaw alanshaw referenced this pull request in alanshaw/david-www Jul 10, 2013

Closed

Stablalise the search #40

@olizilla

This comment has been minimized.

Show comment Hide comment
@olizilla

olizilla Sep 2, 2013

Bump 👍

olizilla commented Sep 2, 2013

Bump 👍

@isaacs

This comment has been minimized.

Show comment Hide comment
@isaacs

isaacs May 13, 2014

Owner

The test does indeed fail, but the patch doesn't land cleanly, and when I manually clean up the conflicts, it still doesn't pass.

Care to rebase and clean up?

Owner

isaacs commented May 13, 2014

The test does indeed fail, but the patch doesn't land cleanly, and when I manually clean up the conflicts, it still doesn't pass.

Care to rebase and clean up?

@isaacs isaacs closed this May 13, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment