Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Fix #2033 Always accept url deps as valid

  • Loading branch information...
commit 6a8002fa170365fbf1a36f6cd852bce96c3fade1 1 parent 4bea5b0
@isaacs isaacs authored
Showing with 3 additions and 0 deletions.
  1. +3 −0  lib/utils/read-installed.js
View
3  lib/utils/read-installed.js
@@ -94,6 +94,7 @@ var npm = require("../npm.js")
, semver = require("semver")
, readJson = require("./read-json.js")
, log = require("./log.js")
+ , url = require("url")
module.exports = readInstalled
@@ -254,6 +255,8 @@ function findUnmet (obj) {
continue
}
if ( typeof deps[d] === "string"
+ // url deps presumed innocent.
+ && !url.parse(deps[d]).protocol
&& !semver.satisfies(found.version, deps[d])) {
// the bad thing will happen
log.warn(obj.path + " requires "+d+"@'"+deps[d]
Please sign in to comment.
Something went wrong with that request. Please try again.