Permalink
Browse files

publishConfig: conf.save() should save actual config, not pubConf

This avoids an error when the npm-registry-client gets a new token, and
attempts to call conf.save('user').  However, a publishConfig can't save
in this way, because it doesn't have a 'user' file source.

Binding the save to the parent config *does* avoid the error, but of course,
at the cost of making the save in this situation a no-op.
  • Loading branch information...
isaacs committed Feb 3, 2014
1 parent b99d465 commit c0ac83224d49aa62e55577f8f27d53bbfd640dc5
Showing with 1 addition and 0 deletions.
  1. +1 −0 lib/publish.js
View
@@ -72,6 +72,7 @@ function publish_ (arg, data, isRetry, cachedir, cb) {
var registry = npm.registry
if (data.publishConfig) {
var pubConf = new Conf(npm.config)
+ pubConf.save = npm.config.save.bind(npm.config)
// don't modify the actual publishConfig object, in case we have
// to set a login token or some other data.

0 comments on commit c0ac832

Please sign in to comment.