Permalink
Browse files

Revert "Quote paths passed to child_process.exec."

This reverts commit 391b8a3.

This causes problems on unix when running the tests, which is much more
common.

The test runner needs to probably just be redone in a better way.  It's
old and janky, and has been ported from bash to js, but ought to be
replaced with something that exercises npm's functionality in a more
proper way.
  • Loading branch information...
1 parent 53c7e2c commit e5fafaf2ea30437445387cce929939ee3091f176 @isaacs isaacs committed Jun 18, 2012
Showing with 2 additions and 2 deletions.
  1. +2 −2 test/run.js
View
@@ -72,8 +72,8 @@ function exec (cmd, shouldFail, cb) {
// special: replace 'node' with the current execPath,
// and 'npm' with the thing we installed.
var cmdShow = cmd
- cmd = cmd.replace(/^npm /, "\"" + path.resolve(npmPath, "npm") + "\" ")
- cmd = cmd.replace(/^node /, "\"" + process.execPath + "\" ")
+ cmd = cmd.replace(/^npm /, path.resolve(npmPath, "npm") + " ")
+ cmd = cmd.replace(/^node /, process.execPath + " ")
child_process.exec(cmd, {env: env}, function (er, stdout, stderr) {
if (stdout) {

0 comments on commit e5fafaf

Please sign in to comment.