Skip to content
This repository has been archived by the owner on Aug 11, 2022. It is now read-only.

tar.js no indexOf on npm publish #1443

Closed
aikar opened this issue Sep 22, 2011 · 4 comments
Closed

tar.js no indexOf on npm publish #1443

aikar opened this issue Sep 22, 2011 · 4 comments

Comments

@aikar
Copy link

aikar commented Sep 22, 2011

info it worked if it ends with ok
verbose cli [ 'node', '/usr/local/bin/npm', 'publish' ]
info using npm@1.0.30
info using node@v0.4.12
verbose config file /home/aikar/.npmrc
verbose config file /usr/local/etc/npmrc
verbose publish [ '.' ]
silly testEngine { name: 'nope',
silly testEngine version: '1.0.1',
silly testEngine author:
silly testEngine { name: 'Aikar',
silly testEngine email: 'aikar@aikar.co',
silly testEngine url: 'http://www.aikar.co' },
silly testEngine main: 'lib/nope.js',
silly testEngine engines: { node: '>=0.4' },
silly testEngine dependencies: {},
silly testEngine bundledDependencies:
silly testEngine { autoloader: '',
silly testEngine nope: '',
silly testEngine 'nope.js': '',
silly testEngine joose: '',
silly testEngine 'joosex-class-simpleconstructor': '',
silly testEngine 'joosex-class-singleton': '',
silly testEngine 'joosex-meta-lazy': '' },
silly testEngine _npmJsonOpts:
silly testEngine { file: '/home/aikar/projects/nope/package.json',
silly testEngine wscript: false,
silly testEngine contributors: false,
silly testEngine serverjs: false },
silly testEngine _id: 'nope@1.0.1',
silly testEngine devDependencies: {},
silly testEngine _engineSupported: true,
silly testEngine _npmVersion: '1.0.30',
silly testEngine _nodeVersion: 'v0.4.12',
silly testEngine _defaultsLoaded: true,
silly testEngine scripts: {} }
verbose caching /home/aikar/projects/nope/package.json
verbose loadDefaults nope@1.0.1
info prepublish nope@1.0.1
verbose cache add [ '.', null ]
silly cache add: name, spec, args [ undefined, '.', [ '.', null ] ]
verbose parsed url { pathname: '.', href: '.' }
silly testEngine { name: 'nope',
silly testEngine version: '1.0.1',
silly testEngine author:
silly testEngine { name: 'Aikar',
silly testEngine email: 'aikar@aikar.co',
silly testEngine url: 'http://www.aikar.co' },
silly testEngine main: 'lib/nope.js',
silly testEngine engines: { node: '>=0.4' },
silly testEngine dependencies: {},
silly testEngine _npmJsonOpts:
silly testEngine { file: 'package.json',
silly testEngine wscript: false,
silly testEngine contributors: false,
silly testEngine serverjs: false },
silly testEngine _id: 'nope@1.0.1',
silly testEngine devDependencies: {},
silly testEngine _engineSupported: true,
silly testEngine _npmVersion: '1.0.30',
silly testEngine _nodeVersion: 'v0.4.12',
silly testEngine _defaultsLoaded: true,
silly testEngine path: '/home/aikar/projects/nope',
silly testEngine bundleDependencies:
silly testEngine { autoloader: '',
silly testEngine nope: '',
silly testEngine 'nope.js': '',
silly testEngine joose: '',
silly testEngine 'joosex-class-simpleconstructor': '',
silly testEngine 'joosex-class-singleton': '',
silly testEngine 'joosex-meta-lazy': '' } }
verbose caching package.json
verbose loadDefaults nope@1.0.1
verbose pack /home/aikar/projects/nope /tmp/npm-1316662313185/1316662313185-0.2129972050897777/tmp.tgz
ERR! TypeError: Object # has no method 'indexOf'
ERR! at /usr/local/lib/node_modules/npm/lib/utils/tar.js:522:18
ERR! at Array.filter (native)
ERR! at filterNodeModules (/usr/local/lib/node_modules/npm/lib/utils/tar.js:518:16)
ERR! at next (/usr/local/lib/node_modules/npm/lib/utils/tar.js:474:15)
ERR! at /usr/local/lib/node_modules/npm/lib/utils/tar.js:432:48
ERR! at cb (/usr/local/lib/node_modules/npm/node_modules/slide/lib/async-map.js:48:11)
ERR! at /usr/local/lib/node_modules/npm/lib/utils/tar.js:332:24
ERR! at /usr/local/lib/node_modules/npm/lib/utils/read-json.js:86:22
ERR! at P (/usr/local/lib/node_modules/npm/lib/utils/read-json.js:104:22)
ERR! at cb (/usr/local/lib/node_modules/npm/node_modules/graceful-fs/graceful-fs.js:37:9)
ERR! Report this entire log at:
ERR! http://github.com/isaacs/npm/issues
ERR! or email it to:
ERR! npm-@googlegroups.com
ERR!
ERR! System Linux 2.6.38-11-generic
ERR! command "node" "/usr/local/bin/npm" "publish"
ERR! cwd /home/aikar/projects/nope
ERR! node -v v0.4.12
ERR! npm -v 1.0.30
verbose exit [ 1, true ]

@isaacs
Copy link
Contributor

isaacs commented Sep 23, 2011

bundledDependencies needs to be an array, not a hash. http://npmjs.org/doc/json.html#bundledDependencies

@isaacs isaacs closed this as completed Sep 23, 2011
@aikar
Copy link
Author

aikar commented Sep 23, 2011

oh oops... maybe add error detection for that? I thought it followed same style of listing versions.

@aikar
Copy link
Author

aikar commented Sep 23, 2011

How would i make my node_modules/nope.js symlink not be excluded? I tried nope.js and nope, neither worked.
I do not want to symlink the directory to avoid recursive symlinks.

@isaacs
Copy link
Contributor

isaacs commented Sep 23, 2011

npm should handle recursive symlinks just fine. You'll end up with a copy of the folder at the time of its creation, rather than a symlink in the package.

mfncooper pushed a commit to mfncooper/npm that referenced this issue Oct 2, 2011
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants