Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

uidNumber provides undefined uid and gid #1613

Closed
mfncooper opened this Issue · 3 comments

5 participants

@mfncooper
Collaborator

The first line of the uidNumber function:

https://github.com/isaacs/npm/blob/master/lib/utils/uid-number.js#L18

may call the callback with no error but undefined values for uid and gid. Those undefined values are later passed in to unpack_ and show up in the verbose logs:

https://github.com/isaacs/npm/blob/master/lib/utils/tar.js#L163

I'm not 100% sure that this is unintended, but it doesn't "feel" right.

@isaacs
Owner

I think this is probably a bug, but it's working right now on windows (and with --unsafe-perm enabled) so I think it's probably being worked around at some other area. If you feel like combing through it, be my guest :)

@timoxley
Collaborator

@mfncooper is this still an issue? Perhaps it should live as a bug on https://github.com/isaacs/uid-number

#4430

@iarna iarna added the bug label
@othiym23
Owner

Closing as abandoned.

@othiym23 othiym23 closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.