NPM bugs should open browser window in the background, not block until browser window closes #1776

Closed
markcowl opened this Issue Nov 23, 2011 · 3 comments

Comments

Projects
None yet
4 participants
@markcowl

No description provided.

@isaacs

This comment has been minimized.

Show comment Hide comment
@isaacs

isaacs Nov 23, 2011

Member

Looks like bugs and docs are both broken on Windows. Oddly, it's opening the browser properly for npm help, so I need to work out what the diff is there.

Member

isaacs commented Nov 23, 2011

Looks like bugs and docs are both broken on Windows. Oddly, it's opening the browser properly for npm help, so I need to work out what the diff is there.

@jordan0day

This comment has been minimized.

Show comment Hide comment
@jordan0day

jordan0day Dec 29, 2011

bugs and docs both implement an "open" function that exec's npm.config.get("browser"), while help exec's cmd, passing the url to the help html as an argument.

Personally I like bugs and docs implementation better. The version implemented in help.js will open up the file in whatever program Windows has associated with the .html extension, which I imagine in many dev's case is an editor, not a browser. The main downside is it requires the user to set up their npm browser config setting manually.

bugs and docs both implement an "open" function that exec's npm.config.get("browser"), while help exec's cmd, passing the url to the help html as an argument.

Personally I like bugs and docs implementation better. The version implemented in help.js will open up the file in whatever program Windows has associated with the .html extension, which I imagine in many dev's case is an editor, not a browser. The main downside is it requires the user to set up their npm browser config setting manually.

@domenic

This comment has been minimized.

Show comment Hide comment
@domenic

domenic Aug 6, 2012

Member

Does not block for me.

Member

domenic commented Aug 6, 2012

Does not block for me.

@domenic domenic closed this Mar 11, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment