Rebuild assumes it should runs make clean without assuming it should run make build #2195

Closed
jstewmon opened this Issue Feb 24, 2012 · 2 comments

Projects

None yet

2 participants

@jstewmon

The fix for #1872 is a naughty one. It results in the deletion of files that are built and packaged by publishers who use make files, but don't specify npm scripts because they don't have C++ addons.

This affects less and async in my project.

If you jump the track to call clean, you should jump the track to call build. IMO, this was a bad call because it assumes that a makefile exists to work in conjunction with the npm build process.

This is especially bothersome because it can break an application during deployment for those following the advice to commit the node_modules directory and run npm rebuild on a server durning a deployment. That's how I've been doing my deployments, and it took me a whole day to figure out why the minified files that were in my repo were missing from my servers.

@isaacs
Member
isaacs commented Feb 24, 2012

Yeah, I think that behavior probably just needs to be reverted, at least for make clean. Doing node-waf clean is probably still worth doing, since I doubt anyone is building anything with wscripts by choice.

@jstewmon jstewmon added a commit to jstewmon/async that referenced this issue Feb 24, 2012
@jstewmon jstewmon deployment fix for issue caused by npm/npm#2195 a6966a8
@jstewmon jstewmon referenced this issue in caolan/async Feb 24, 2012
Merged

npm 1.1.1 compatibility fix #103

@isaacs
Member
isaacs commented Feb 29, 2012

Fixed on master by removing the "make clean" bit.

@isaacs isaacs closed this Feb 29, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment