Getting the wrong etag from npm-registry-client #2532

Closed
isaacs opened this Issue Jun 17, 2012 · 1 comment

Comments

Projects
None yet
1 participant
@isaacs
Owner

isaacs commented Jun 17, 2012

Leading to a lot of unnecessary requests that could be 304s. (Almost certainly a bug in https://github.com/isaacs/npm-registry-client)

[gh:npm/master]isaacs@tum.local:~/dev/js/npm v0.7.12-pre 4.1.0(1)-release
$ npm cache clean express

[gh:npm/master]isaacs@tum.local:~/dev/js/npm v0.7.12-pre 4.1.0(1)-release
$ npm cache add express
npm http GET https://registry.npmjs.org/express
npm http 200 https://registry.npmjs.org/express
npm http GET https://registry.npmjs.org/express/-/express-2.5.10.tgz

[gh:npm/master]isaacs@tum.local:~/dev/js/npm v0.7.12-pre 4.1.0(1)-release
$ cat /Users/isaacs/.npm/express/.cache.json | json _etag
"885Z09F9TP77WNACOP5AJ04SV"

[gh:npm/master]isaacs@tum.local:~/dev/js/npm v0.7.12-pre 4.1.0(1)-release
$ curl -I https://registry.npmjs.org/express
HTTP/1.1 200 OK
Vary: Accept
Server: CouchDB/1.2.0 (Erlang OTP/R15B)
ETag: "UA3RU8OM63ZI5B1RALZ8ML1K"
Date: Sun, 17 Jun 2012 19:50:05 GMT
Content-Type: application/json
Content-Length: 141693
@isaacs

This comment has been minimized.

Show comment Hide comment
@isaacs

isaacs Aug 17, 2012

Owner

Fixed some time ago.

Owner

isaacs commented Aug 17, 2012

Fixed some time ago.

@isaacs isaacs closed this Aug 17, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment