Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Shims being created with absolute paths in npm 1.1.32 #2572

Closed
ddollar opened this Issue Jun 26, 2012 · 3 comments

Comments

Projects
None yet
3 participants

ddollar commented Jun 26, 2012

Has the behavior fixed in #104 intentionally changed or regressed?

$ npm install npm@1.1.9 -g
npm http GET https://registry.npmjs.org/npm/1.1.9
npm http 200 https://registry.npmjs.org/npm/1.1.9
...

$ npm -v
1.1.9

$ rm -rf node_modules; npm install
npm http GET https://registry.npmjs.org/coffee-script
npm http GET https://registry.npmjs.org/connect-form

$ ls -la node_modules/.bin
total 32
drwxr-xr-x   6 david  staff  204 Jun 26 14:02 .
drwxr-xr-x  11 david  staff  374 Jun 26 14:02 ..
lrwxr-xr-x   1 david  staff   25 Jun 26 14:02 cake -> ../coffee-script/bin/cake
lrwxr-xr-x   1 david  staff   27 Jun 26 14:02 coffee -> ../coffee-script/bin/coffee
lrwxr-xr-x   1 david  staff   22 Jun 26 14:02 express -> ../express/bin/express
lrwxr-xr-x   1 david  staff   21 Jun 26 14:02 nodemon -> ../nodemon/nodemon.js

$ npm install npm@1.1.32 -g
npm http GET https://registry.npmjs.org/npm/1.1.32
npm http 200 https://registry.npmjs.org/npm/1.1.32
...

$ npm -v
1.1.32

$ rm -rf node_modules; npm install
npm http GET https://registry.npmjs.org/coffee-script
npm http GET https://registry.npmjs.org/connect-form

$ ls -la node_modules/.bin
total 32
drwxr-xr-x   6 david  staff  204 Jun 26 14:04 .
drwxr-xr-x  11 david  staff  374 Jun 26 14:04 ..
lrwxr-xr-x   1 david  staff   81 Jun 26 14:04 cake -> /Users/david/Dropbox/David/code/vulcan/server/node_modules/coffee-script/bin/cake
lrwxr-xr-x   1 david  staff   83 Jun 26 14:04 coffee -> /Users/david/Dropbox/David/code/vulcan/server/node_modules/coffee-script/bin/coffee
lrwxr-xr-x   1 david  staff   78 Jun 26 14:04 express -> /Users/david/Dropbox/David/code/vulcan/server/node_modules/express/bin/express
lrwxr-xr-x   1 david  staff   77 Jun 26 14:04 nodemon -> /Users/david/Dropbox/David/code/vulcan/server/node_modules/nodemon/nodemon.js

bissecting the taged versions narrows it down to the commits between 1.1.25 to 1.1.26. I'll try to find this evil bug! :)

it's actually this commit: 0892bab

@isaacs isaacs closed this in df97de6 Jun 27, 2012

Owner

isaacs commented Jun 27, 2012

I had to make them absolute on Windows, and just missed that one. It should still work fine, as long as you're not moving things around, but it'll be back to relatives in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment