Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Should install fail if a defaulted install script fails? #2983

Closed
mfncooper opened this Issue · 2 comments

3 participants

@mfncooper
Collaborator

When a wscript file is present in the root of a package, and no (pre)install script is specified, that script gets run using node-waf. This was introduced a really long time ago (#72).

On a rebuild, any error in running node-waf in this way is ignored. See #1872 and:

https://github.com/isaacs/npm/blob/master/lib/rebuild.js#L32

However, at install time, a node-waf error (like node-waf not being there, for example) causes installation to fail.

Given how obsolete node-waf is now, should we allow install to succeed (i.e. ignore errors) if the install script is defaulted to running node-waf, and that fails?

@iarna iarna added the support label
@smikes

Is this still a problem for you?

Is this a problem that you can still reproduce in current npm (2.1.8) with a non-obsolete package? Since you filed this issue, node-waf has only gotten more obsolete, and I don't think any modern code should depend on packages that use wscript.

We are trying to clean up older npm issues, so if we don't hear back from you within a week, we will close this issue. (Don't worry -- you can always come back again and re-open it!)

Thanks!

@iarna
Owner

We haven’t heard anything from you, so I’m going to close this ticket and hope you solved your problem on your own. If you’re still having problems please reopen this or open a new ticket. Thanks!

@iarna iarna closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.