Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Should install fail if a defaulted install script fails? #2983
When a wscript file is present in the root of a package, and no (pre)install script is specified, that script gets run using node-waf. This was introduced a really long time ago (#72).
On a rebuild, any error in running node-waf in this way is ignored. See #1872 and:
However, at install time, a node-waf error (like node-waf not being there, for example) causes installation to fail.
Given how obsolete node-waf is now, should we allow install to succeed (i.e. ignore errors) if the install script is defaulted to running node-waf, and that fails?
This comment has been minimized.
This comment has been minimized.Show comment Hide comment
Is this still a problem for you?
Is this a problem that you can still reproduce in current npm (2.1.8) with a non-obsolete package? Since you filed this issue, node-waf has only gotten more obsolete, and I don't think any modern code should depend on packages that use wscript.
We are trying to clean up older npm issues, so if we don't hear back from you within a week, we will close this issue. (Don't worry -- you can always come back again and re-open it!)