Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Remove lib/utils/exec.js #3312

Closed
isaacs opened this Issue · 4 comments

3 participants

@isaacs
Owner

We should just use child_process.spawn and child_process.exec instead. This util is a throwback to the old days when those functions lacked the functionality we needed.

cc: @ForbesLindesay

@ForbesLindesay

Yes, I had thought it was related to handling cross platform issues with spawn (on windows spawn doesn't respect #!/usr/bin/env node). I guess those issues are handled using cmd-shim though.

@robertkowalski
Collaborator

I could start with it soon, anything I have to take care of?

@isaacs
Owner

You have my permission to fix this. Full speed ahead :)

@robertkowalski robertkowalski referenced this issue from a commit in robertkowalski/npm
@robertkowalski robertkowalski remove exec.js, fixes #3312 bbbb00f
@robertkowalski robertkowalski referenced this issue from a commit in robertkowalski/npm
@robertkowalski robertkowalski remove exec.js, fixes #3312 5e591f7
@robertkowalski robertkowalski referenced this issue from a commit in robertkowalski/npm
@robertkowalski robertkowalski remove exec.js, fixes #3312 e4eb626
@robertkowalski
Collaborator

pull request is now ready

@isaacs isaacs closed this in 8e879f5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.