Remove lib/utils/exec.js #3312

Closed
isaacs opened this Issue Apr 4, 2013 · 4 comments

Projects

None yet

3 participants

@isaacs
npm member

We should just use child_process.spawn and child_process.exec instead. This util is a throwback to the old days when those functions lacked the functionality we needed.

cc: @ForbesLindesay

@ForbesLindesay
npm member

Yes, I had thought it was related to handling cross platform issues with spawn (on windows spawn doesn't respect #!/usr/bin/env node). I guess those issues are handled using cmd-shim though.

@robertkowalski
npm member

I could start with it soon, anything I have to take care of?

@isaacs
npm member

You have my permission to fix this. Full speed ahead :)

@robertkowalski robertkowalski added a commit to robertkowalski/npm that referenced this issue Apr 27, 2013
@robertkowalski robertkowalski remove exec.js, fixes #3312 bbbb00f
@robertkowalski robertkowalski added a commit to robertkowalski/npm that referenced this issue Apr 27, 2013
@robertkowalski robertkowalski remove exec.js, fixes #3312 5e591f7
@robertkowalski robertkowalski added a commit to robertkowalski/npm that referenced this issue Apr 27, 2013
@robertkowalski robertkowalski remove exec.js, fixes #3312 e4eb626
@robertkowalski
npm member

pull request is now ready

@isaacs isaacs closed this in 8e879f5 Apr 29, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment