prepublish is never triggered when using git urls #3423

Closed
Gottox opened this Issue May 8, 2013 · 1 comment

Comments

Projects
None yet
2 participants
@Gottox

Gottox commented May 8, 2013

I've got the problem, that I'm using the prepublish hook for compiling some modules with browserify. Unfortunately this hook is triggered when I'm releasing the module to npmjs.org, but it won't be triggered if someone puts the git url in package.json.

The documentation of npm stats that using the install hook (which works for my purpose) is an antipattern.

I recommend a new hook which serves this purpose, removing the antipattern from documentation or let prepublish be triggered on github urls on install too.

@domenic

This comment has been minimized.

Show comment Hide comment
@domenic

domenic May 10, 2013

Member

Yeah, we definitely want this; see #3055.

Member

domenic commented May 10, 2013

Yeah, we definitely want this; see #3055.

@domenic domenic closed this May 10, 2013

@alliv8 alliv8 referenced this issue in shimaore/esl Oct 28, 2013

Closed

Cant fork successfully #10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment