Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

npm install python version check. #3467

Open
jonaspeeck opened this Issue · 6 comments

5 participants

@jonaspeeck

Original post:
joyent/node#5527 (comment)

tl;dr: Python version check in npm install would make the life of node.js beginners under Windows a lot easier although it seems to be rather an issue by gyp not by node.js.
Still a one liner that would make node.js even more fun to use :)

Thanks :)

@domenic
Collaborator

I agree this would be pretty helpful. Not sure if it belongs in npm or in node-gyp though (probably the latter). @TooTallNate, any thoughts on that?

@TooTallNate

I mean I already do check the Python version before executing gyp: https://github.com/TooTallNate/node-gyp/blob/be288a75fc9bd5652e3e9806a7b673c2bdf61313/lib/configure.js#L92-L121

@jonaspeeck Where/when would you expect this version check to happen?

@domenic
Collaborator

@TooTallNate wow that code looks perfect. Very curious what @jonaspeeck's logs looked like where he didn't see that problem immediately...

@jonaspeeck

Hey guys. I'm busy with an important homework assignment for college which is due in roughly 24 hours. So I'll try to reproduce the error and the logs in the next couple of days and will get back to you on that!

@robertkowalski
Collaborator

@jonaspeeck do you have an update?

@TooTallNate

Close? (doesn't seem like npm's responsibility in the first place)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.