Issue warning when running "shrinkwrap" with active "npm links" #4351

Closed
rprieto opened this Issue Dec 20, 2013 · 1 comment

Comments

Projects
None yet
3 participants
@rprieto

rprieto commented Dec 20, 2013

I had a case recently where I was working on related modules, so I:

/dev/my-module $  npm link

/dev/my-app    $  npm link my-module
/dev/my-app    $  ls -la node_modules

lrwxr-xr-x   Romain   my-module -> /usr/local/lib/node_modules/my-module

If you forget about it and run npm shrinkwrap, it generates:

{
  "my-module": {
    "version": "0.0.3",
    "dependencies": {}
  }
}

instead of the more complete:

{
  "my-module": {
     "version": "1.0.3",
     "from": "git+https://github.com/owner/repo.git#v1.0.3",
     "resolved": "git+https://github.com/owner/repo.git#v1.0.3",
     "dependencies": {}
  }
}

If the module isn't on NPM (like above), this is a problem.

If it's hard to fix, a warning saying "careful: you have active linked modules" would be very helpful.

@iarna iarna added the bug label Oct 3, 2014

@npm-robot

This comment has been minimized.

Show comment
Hide comment
@npm-robot

npm-robot Jun 19, 2017

We're closing this issue as it has gone thirty days without activity. In our experience if an issue has gone thirty days without any activity then it's unlikely to be addressed. In the case of bug reports, often the underlying issue will be addressed but finding related issues is quite difficult and often incomplete.

If this was a bug report and it is still relevant then we encourage you to open it again as a new issue. If this was a feature request then you should feel free to open it again, or even better open a PR.

For more information about our new issue aging policies and why we've instituted them please see our blog post.

We're closing this issue as it has gone thirty days without activity. In our experience if an issue has gone thirty days without any activity then it's unlikely to be addressed. In the case of bug reports, often the underlying issue will be addressed but finding related issues is quite difficult and often incomplete.

If this was a bug report and it is still relevant then we encourage you to open it again as a new issue. If this was a feature request then you should feel free to open it again, or even better open a PR.

For more information about our new issue aging policies and why we've instituted them please see our blog post.

@npm-robot npm-robot closed this Jun 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment