Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Issue warning when running "shrinkwrap" with active "npm links" #4351

Open
rprieto opened this Issue · 0 comments

2 participants

@rprieto

I had a case recently where I was working on related modules, so I:

/dev/my-module $  npm link

/dev/my-app    $  npm link my-module
/dev/my-app    $  ls -la node_modules

lrwxr-xr-x   Romain   my-module -> /usr/local/lib/node_modules/my-module

If you forget about it and run npm shrinkwrap, it generates:

{
  "my-module": {
    "version": "0.0.3",
    "dependencies": {}
  }
}

instead of the more complete:

{
  "my-module": {
     "version": "1.0.3",
     "from": "git+https://github.com/owner/repo.git#v1.0.3",
     "resolved": "git+https://github.com/owner/repo.git#v1.0.3",
     "dependencies": {}
  }
}

If the module isn't on NPM (like above), this is a problem.

If it's hard to fix, a warning saying "careful: you have active linked modules" would be very helpful.

@iarna iarna added the bug label
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.