Renaming gypfiles causes broken builds #4630

Open
stephenmathieson opened this Issue Feb 9, 2014 · 4 comments

Projects

None yet

6 participants

@stephenmathieson

This relates to #2372.

I've got a non-npm dependency in a native module, which happens to have a package.json file. This confuses npm and causes it to rename this gypfile to binding.gyp, thus breaking my build.

Broken tarball: http://registry.npmjs.org/sophist/-/sophist-0.2.0.tgz

TLDR;

Please don't rename gypfiles.

@stephenmathieson stephenmathieson added a commit to stephenmathieson/node-sophist that referenced this issue Feb 9, 2014
@stephenmathieson stephenmathieson Remove package.json from list dep.
npm renames list.gyp -> binding.gyp for an unknown reason.  See npm/npm#4630.
0261552
@rlidwka
Contributor
rlidwka commented Feb 9, 2014

nodejs/node-v0.x-archive#3113

definitely an npm bug

@jeremiegirault

It also breaks my build. Please don't rename gypfiles

@othiym23 othiym23 added the bug label Sep 26, 2014
@busches
busches commented Sep 26, 2016

@stephenmathieson is this bug still occurring using the latest npm@2 or npm@3?

cc/ @KenanY

@KenanY
Member
KenanY commented Sep 26, 2016

Reminds me of npm/fstream-npm#18.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment