Skip to content
This repository has been archived by the owner. It is now read-only.

lib: Add sign-git-commit config #12697

Merged
merged 2 commits into from Jul 10, 2018
Merged

Conversation

@tribou
Copy link
Contributor

@tribou tribou commented May 13, 2016

Adds sign-git-commit config referenced in #12696

@tribou tribou force-pushed the 12696-git-sign-commit branch from a151a0d to 33191e6 May 13, 2016
zkat
zkat approved these changes Mar 7, 2018
Copy link
Contributor

@zkat zkat left a comment

This LGTM! It seems reasonable enough to include, so we'll have it as part of the next release. Thanks!

@tribou
Copy link
Contributor Author

@tribou tribou commented Mar 7, 2018

@zkat Just a heads up! I originally wrote this PR against npm@^3 and haven't tested it at all in v5 😟

I'm afraid it might need to be rewritten 😢

@zkat
Copy link
Contributor

@zkat zkat commented Mar 7, 2018

@tribou I think you'll find the conflict to be very small! It would be great if you just resolved the conflict and pushed out a new, rebased version -- or I can do it myself when it's time to merge (although that'd be more work for me lolsob). Your patch is straightforward enough :)

@tribou
Copy link
Contributor Author

@tribou tribou commented Mar 7, 2018

Ah, I didn't realize that! I'll try to look into it soon

@zkat
Copy link
Contributor

@zkat zkat commented Mar 8, 2018

I'm doing my merges today, and it looks like this isn't ready yet, so I'm pushing it out until next time we do a PR sweep.

@zkat zkat removed the target-latest label Mar 8, 2018
@zkat zkat force-pushed the release-next branch 5 times, most recently from 83a5d44 to a571f80 Mar 12, 2018
@iarna iarna force-pushed the release-next branch 3 times, most recently from bcc4670 to 4a65b3b Mar 23, 2018
@zkat zkat force-pushed the release-next branch from 748c06e to ada9c6c Apr 4, 2018
@iarna iarna force-pushed the release-next branch 5 times, most recently from 2e76172 to fe31e66 Apr 13, 2018
@iarna iarna force-pushed the release-next branch 2 times, most recently from 63c9452 to 1b021d0 Apr 21, 2018
@iarna iarna force-pushed the release-next branch 2 times, most recently from 691cb35 to bf3cfa7 May 11, 2018
@iarna iarna force-pushed the release-next branch 6 times, most recently from 3f32220 to f29b7a6 May 24, 2018
@zkat zkat requested a review from as a code owner Jul 10, 2018
@zkat zkat merged commit 7984206 into npm:release-next Jul 10, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants