This repository has been archived by the owner on Aug 11, 2022. It is now read-only.
install: Use EXDEV aware move instead of rename #15901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 1, 2017
graingert
reviewed
Mar 1, 2017
| @@ -1,16 +0,0 @@ | |||
| 'use strict' | |||
There was a problem hiding this comment.
might be worth leaving this as an empty file so it doesn't break anyone using:
# Fix bug https://github.com/npm/npm/issues/9863
RUN cd $(npm root -g)/npm \
&& npm install fs-extra \
&& sed -i -e s/graceful-fs/fs-extra/ -e s/fs\.rename/fs.move/ ./lib/utils/rename.js
There was a problem hiding this comment.
I'm grumpy about it but yeah, since this is fixing things for exactly the folks who would have had that patch, we probably shouldn't break the work around. =D
There was a problem hiding this comment.
We'll remove the hack w/ npm@5, since it's a breaking bump anyway.
|
@legodude17 Ack, I hit the wrong button and deleted your comment, but this is failing because I missed adding |
|
@iarna That's ok. By the way, where did appveyor go? I don't see it. |
zkat
pushed a commit
that referenced
this pull request
Mar 9, 2017
zkat
pushed a commit
that referenced
this pull request
Mar 10, 2017
2 tasks
rastaman
added a commit
to rastaman/blueocean-plugin
that referenced
this pull request
Oct 10, 2017
ediblecode
added a commit
to nice-digital/NICE.TopHat
that referenced
this pull request
Nov 7, 2017
This is to use newer version of npm by default, to fix npm/npm#15901
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow moving across devices and moving when filesystems don't
support renaming directories full of files.
Fixes: #9863 (hopefully)