This repository has been archived by the owner on Aug 11, 2022. It is now read-only.
fix(git): git repos with prepare scripts always install with dev flag #17060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zkat
suggested changes
Jun 7, 2017
lib/pack.js
Outdated
| @@ -163,6 +163,7 @@ function packGitDep (manifest, dir) { | |||
| const child = cp.spawn(process.env.NODE || process.execPath, [ | |||
| require.main.filename, | |||
| 'install', | |||
| '--only=dev', | |||
There was a problem hiding this comment.
This will only install devDependencies and not dependencies. Did you want to use --dev?
There was a problem hiding this comment.
I did originally have --dev but when I used it locally it told me that it's deprecated and that i should be using --only=dev so I assumed the name was misleading :)
Guess not and will revert back to --dev
|
Addressed comments :) (not sure if you get a notification for that) |
iarna
reviewed
Jun 27, 2017
| @@ -163,6 +163,7 @@ function packGitDep (manifest, dir) { | |||
| const child = cp.spawn(process.env.NODE || process.execPath, [ | |||
| require.main.filename, | |||
| 'install', | |||
| '--dev', | |||
There was a problem hiding this comment.
I think there should be a --prod here as well to protect us against users who were doing an --only=dev install previously.
There was a problem hiding this comment.
SGTM and solved :)
intellix
force-pushed
the
git-prepare-dev
branch
from
accc885
to
ebf1927
Compare
zkat
approved these changes
Jun 29, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Force devDependencies to always install with --dev flag in case NODE_ENV is production
Related: #16533
Closes #17059