Fix assignment of repo in init command #2325

wants to merge 1 commit into


None yet

2 participants

npm member

In the init command, the code for setting the repo works, but only accidentally. The defaultRepo function constructs the correct repo object, but this is then clobbered and replaced by a string. The processJson function sees that a string has been provided instead of an object, and reconstructs the object again. (You can see the bug in action by temporarily changing the repo type string in defaultRepo; the type will still be "git" when the package.json contents are created.)

npm member

landed, thanks!

@isaacs isaacs closed this Apr 6, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment