Npat test reporting works! #2504

Closed
wants to merge 5 commits into
from

Projects

None yet

4 participants

@DTrejo

This is mostly to start a discussion.

Current problems:

  1. is probably a bit verbose, it prints a success message with info on where your test data was stored
  2. stdout and stderr data are not passed on to the exec callback! I need to figure out why this is. relevant lines: https://github.com/DTrejo/npm/blob/npat-dtrejo/lib/utils/lifecycle.js#L158-164
  3. I need to double-check that it is all compliant with npm styleguide
  4. I need to rebase and fix all the commit messages so they are prettier and more descriptive.
  5. ?

Let me know your thoughts, especially with # 3! Maybe there's something obvious that I'm not doing.

Thanks,
D

PS It was good that I waited 6 months to submit this — the bug that was stopping me has mysteriously disappeared :)

@ralt

9 months without any news. Is there still some work involved, planned or not? Is it awaiting review?

@DTrejo
@luk-

@DTrejo I'm going to close this out for housekeeping because it looks abandoned, but if you want to pick it back up let someone know.

@luk- luk- closed this Dec 3, 2013
@DTrejo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment