This repository has been archived by the owner on Aug 11, 2022. It is now read-only.
Added file/url completion for "install" command. #2612
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, I know it's been a while. Would you mind rebasing onto the current master branch? |
|
Sure thing. Will get on it soon. |
|
@isaacs this still something we want? |
|
At long last, this has been rebased, squashed, tweaked, and landed as d7b7853. Thank you very much for putting this together back when we were all younger, more innocent, and hopeful for the future. |
|
Oh wow, I had completely forgotten about this. Much embarrassed. Excellent work on the rebase! :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried to implement according to the function comment block.