WARN if npm-shrinkwrap.json is present #2660

Closed
wants to merge 2 commits into
from

2 participants

@glennblock

This small patch outputs a warning if npm-shrinkwrap.json is present. This is generally useful for informing the user that the shrinkwrap file has been picked up. In particular it is useful for cloud providers which dump the console output and where the user may not know if shrinkwrap is supported.

@isaacs
npm member

Making this a warning seems a bit excessive. Is log.info enough? Typically you'd be running npm install in your own project or something, where you created the npm-shrinkwrap.json file yourself, right?

@glennblock
@isaacs
npm member

Right, but what i'm saying is:

I've put a shrinkwrap.json in my git repo, then push it to you, then you warn me about it? That sounds weird to me.

Typically, we warn about unexpected behavior, not things working exactly as designed because the user explicitly asked for it.

@isaacs isaacs closed this Aug 15, 2012
@glennblock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment