Windows command echoing #2916

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
@perfusorius

Avoid echoing command on the cli by adding a preceding "@" (when no shebang is defined)

Adresses #2915

Update lib/utils/cmd-shim.js
Avoid echoing command on the cli by adding a preceding "@" (when no shebang is defined)

Adresses #2915
@domenic

This comment has been minimized.

Show comment Hide comment
@domenic

domenic Mar 11, 2013

Member

I'd be interested in accepting this, but can't quite understand the original description in #2915. Can you do a screenshot before and after the change, with an example package?

Member

domenic commented Mar 11, 2013

I'd be interested in accepting this, but can't quite understand the original description in #2915. Can you do a screenshot before and after the change, with an example package?

@edef1c

This comment has been minimized.

Show comment Hide comment
@edef1c

edef1c Mar 11, 2013

Member

@domenic A cmd file will echo its every line pretty much (sort of like bash -v). The @ silences this.

Member

edef1c commented Mar 11, 2013

@domenic A cmd file will echo its every line pretty much (sort of like bash -v). The @ silences this.

@luk-

This comment has been minimized.

Show comment Hide comment
@luk-

luk- Dec 7, 2013

Contributor

@domenic do you want to try this out on windows sometime

Contributor

luk- commented Dec 7, 2013

@domenic do you want to try this out on windows sometime

@domenic

This comment has been minimized.

Show comment Hide comment
@domenic

domenic Dec 14, 2013

Member

After looking at this further, I don't think this is correct. We do want to echo the command that is being run. We do so on *-nix and there's no reason not to do so on Windows.

Member

domenic commented Dec 14, 2013

After looking at this further, I don't think this is correct. We do want to echo the command that is being run. We do so on *-nix and there's no reason not to do so on Windows.

@domenic domenic closed this Dec 14, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment