fix: npm run-script fails silently. closes #2959 #2960

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants

No description provided.

Not really sure where to put this check. My eyes glazed over a bit when I tried to figure out where the script is actually run.

Member

domenic commented May 27, 2013

+1, @isaacs look good?

Member

mfncooper commented Jun 1, 2013

A full stack-trace-style error seems overly drastic to me. I think just showing a simple error message would be a cleaner way of dealing with this. Like this:

if (!pkg.scripts[cmd]) {
  log.error("run-script", "missing script: " + cmd)
  return cb()
}
Contributor

othiym23 commented Feb 27, 2015

We've gone back and forth on this one a number of times, and at this point this PR is hopelessly stale. Sorry we let it get so long in the tooth, and if the current behavior is still not to your liking, open a new PR and we can try this again.

othiym23 closed this Feb 27, 2015

can you just fix it? as I've demonstrated it's a simple fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment